CLI can't be built if .git is missing (e.g. downloaded zip)

[iliana]

oxide.rs/cli/build.rs

Lines 9 to 13 in 4d5d228

	match built::util::get_repo_head(src.as_ref()) {
	Ok(Some((_branch, _commit, _commit_short))) => (),
	Ok(None) => panic!("Error: Build script could not find git commit information"),
	Err(e) => panic!("Build script error: {}", e),
	};

This will eventually be a pain for downstream distribution packagers.

[iliana]

Also, if you patch out the check, you get a panic at runtime:

$ result/bin/oxide version
Oxide CLI 0.1.0
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', cli/src/cmd_version.rs:31:41
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(17), ...)', cli/src/main.rs:56:10

[ahl]

This will eventually be a pain for downstream distribution packagers.

I expected that we would steer people towards built artifacts e.g. from #19.

[iliana]

I think we can steer customers to pre-built artifacts but a certain type of customer will tend to reach for distro tools for one reason or another. Eventually one of these types of folks will upstream their work into a distro. If it's easy enough to make the equivalent of cargo install work without patches, even if we're less likely to support it, I think we should do that.