Floating point fix for scroll restore (#2086)

david-crespo · web-flow · commit 47835ee3d5e0 · 2024-03-21T03:47:14.000Z
pull in scroll restore fix suggested by @julamb
diff --git a/app/hooks/use-scroll-restoration.ts b/app/hooks/use-scroll-restoration.ts
@@ -10,7 +10,7 @@ import { useLocation, useNavigation } from 'react-router-dom'
 
 function getScrollPosition(key: string) {
   const pos = window.sessionStorage.getItem(key)
-  return pos && /^[0-9]+$/.test(pos) ? parseInt(pos, 10) : 0
+  return Number(pos) || 0
 }
 
 function setScrollPosition(key: string, pos: number) {

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import { useLocation, useNavigation } from 'react-router-dom'`
`10`	`10`
`11`	`11`	`function getScrollPosition(key: string) {`
`12`	`12`	`const pos = window.sessionStorage.getItem(key)`
`13`		`- return pos && /^[0-9]+$/.test(pos) ? parseInt(pos, 10) : 0`
	`13`	`+ return Number(pos) \|\| 0`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`function setScrollPosition(key: string, pos: number) {`