Skip to content

Commit 6897341

Browse files
authored
Try to improve e2e test flake in FF (#2941)
* try to improve e2e test flake * move sleep immediately after the last Enter
1 parent 3f5e7e6 commit 6897341

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

test/e2e/firewall-rules.e2e.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -456,13 +456,13 @@ test('can update firewall rule', async ({ page }) => {
456456
await selectOption(page, 'Protocol filters', 'ICMP')
457457
await page.getByRole('combobox', { name: 'ICMP Type' }).fill('3')
458458
await page.getByRole('combobox', { name: 'ICMP Type' }).press('Enter')
459+
460+
// give FF time to process the above enter before moving to the next field
461+
await sleep(300)
462+
459463
await page.getByRole('textbox', { name: 'ICMP Code' }).fill('0')
460464
await page.getByRole('button', { name: 'Add protocol' }).click()
461465

462-
// targets default vpc
463-
// screen.getByRole('cell', { name: 'vpc' })
464-
// screen.getByRole('cell', { name: 'default' })
465-
466466
// update name
467467
await page.getByRole('textbox', { name: 'Name' }).fill('new-rule-name')
468468

test/e2e/ip-pools.e2e.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,15 +328,19 @@ test('deleting floating IP decrements utilization', async ({ page }) => {
328328

329329
test('no ranges means no utilization bar', async ({ page }) => {
330330
await page.goto('/system/networking/ip-pools/ip-pool-1')
331+
await expect(page.getByRole('heading', { name: 'ip-pool-1' })).toBeVisible()
331332
await expect(page.getByText('Allocated(IPs)')).toBeVisible()
332333

333334
await page.goto('/system/networking/ip-pools/ip-pool-2')
335+
await expect(page.getByRole('heading', { name: 'ip-pool-2' })).toBeVisible()
334336
await expect(page.getByText('Allocated(IPs)')).toBeVisible()
335337

336338
await page.goto('/system/networking/ip-pools/ip-pool-3')
339+
await expect(page.getByRole('heading', { name: 'ip-pool-3' })).toBeVisible()
337340
await expect(page.getByText('Allocated(IPs)')).toBeHidden()
338341

339342
await page.goto('/system/networking/ip-pools/ip-pool-4')
343+
await expect(page.getByRole('heading', { name: 'ip-pool-4' })).toBeVisible()
340344
await expect(page.getByText('Allocated(IPs)')).toBeVisible()
341345

342346
await clickRowAction(page, '::1', 'Remove')

0 commit comments

Comments
 (0)