bump playwright to 1.39 (fix issue with z-index test)

david-crespo · david-crespo · commit ba3a383ed668 · 2023-10-24T15:10:31.000-05:00
No big feature we need, I just had this on my to-do list since upgrading
other deps. I had noticed the z-index test didn't like 1.39 and was
curious if it was an easy fix. Luckily it was. They changed the message
on a thrown error we were matching on.
diff --git a/app/test/e2e/utils.ts b/app/test/e2e/utils.ts
@@ -154,7 +154,7 @@ export async function expectObscured(locator: Locator) {
   // fail fast if not clickable.
   await expect(
     async () => await locator.click({ trial: true, timeout: 50 })
-  ).rejects.toThrow(/locator.click: Timeout 50ms exceeded/)
+  ).rejects.toThrow(/Timeout 50ms exceeded/)
 }
 
 export const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms))
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -75,7 +75,7 @@
   "devDependencies": {
     "@ladle/react": "^3.2.1",
     "@mswjs/http-middleware": "^0.8.0",
-    "@playwright/test": "^1.38.1",
+    "@playwright/test": "^1.39.0",
     "@testing-library/dom": "^9.3.3",
     "@testing-library/jest-dom": "^6.1.4",
     "@testing-library/react": "^14.0.0",

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ export async function expectObscured(locator: Locator) {`
`154`	`154`	`// fail fast if not clickable.`
`155`	`155`	`await expect(`
`156`	`156`	`async () => await locator.click({ trial: true, timeout: 50 })`
`157`		`- ).rejects.toThrow(/locator.click: Timeout 50ms exceeded/)`
	`157`	`+ ).rejects.toThrow(/Timeout 50ms exceeded/)`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`export const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms))`