Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eachLike is different between V2 and V3 Matchers #958

Closed
mefellows opened this issue Oct 3, 2022 · 3 comments
Closed

eachLike is different between V2 and V3 Matchers #958

mefellows opened this issue Oct 3, 2022 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mefellows
Copy link
Member

The definition of eachLike in the V2 and V3 Matchers interface is different, resulting in what is likely to be confusing behaviour.

The V2 version contains a min property, allowing the matching of arbitrary length arrays. The V3 version does not, simply matching on the type/shape itself, which requires the lengths to match.
@mefellows mefellows added the bug Indicates an unexpected problem or unintended behavior label Oct 3, 2022
@candiii-lin
Copy link

Noticing the same! +1

@mefellows
Copy link
Member Author

Would you be up for contributing a PR @candiii-lin ?

hborham added a commit to hborham/pact-js that referenced this issue Dec 8, 2022
@hborham
fix: missing min in v3 eachLike pact-foundation#958
18dbfd4
@hborham hborham mentioned this issue Dec 8, 2022
Merged
3 tasks
mefellows added a commit that referenced this issue Dec 8, 2022
@mefellows
Merge pull request #1019 from hborham/bugfix/eachLike-v3-differs-from-v2
974d247 
fix: missing min in v3 eachLike #958
@hborham
Copy link
Contributor

hborham commented Dec 13, 2022

this should be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mefellows @hborham @candiii-lin