Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retire lodash omitby to fix vulnerability #1175

Merged

Conversation

yukun-han
Copy link
Contributor

@yukun-han yukun-han commented Feb 3, 2024

Checklist

  • npm run dist works locally (this will run tests, lint and build)
  • Commit messages are ready to go in the changelog (see below for details)
  • PR template filled in (see below for details)

Summary

Mentioned in issue #1169, lodash.omitby will be reported security risk by BlackDuck. This PR retired lodash.omitby dependency and replaced it with ramda to avoid vulnerability.

lodash.omitby is used to filter out null and undefined value from a object. ramda does not provide same name omitBy function but this functionality could be achieved by ramda.reject referring to link.

@mefellows
Copy link
Member

Thank for you submitting this, if the build passes I'll bring this in.

@mefellows mefellows merged commit bcc1f57 into pact-foundation:master Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants