chore(ci): add publish as completion dependency #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should _not_ result in failures though, as the `if` only checks for cancelled or failed dependencies (implicitly allowing skipped ones). Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
There was a problem hiding this comment.
Pull Request Overview
This PR adds publish as a dependency to the completion jobs in GitHub Actions workflows to ensure the build is only reported as successful when the deployment is successful or skipped. It also reformats a conditional statement for better readability.
- Adds
publishjob dependency to completion jobs across multiple workflow files - Reformats multi-line conditional statement in test.yml for improved readability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Reformats conditional statement for readability |
| .github/workflows/build.yml | Adds publish dependency to completion job |
| .github/workflows/build-ffi.yml | Adds publish dependency to completion job |
| .github/workflows/build-cli.yml | Adds publish dependency to completion job |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Minor tweak to ensure that the build is not reported as successful unless the deployment is successful (or skipped).
🚨 Breaking Changes🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs