Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Release 2.x (Rename Buildpack to BuildModule for common paths) #265

Merged

Conversation

BarDweller
Copy link

Summary

Updates for libpak for Extension support.

Use Cases

Where appropriate, updates buildpack to be buildmodule, buildmodule represents either a buildpack or an extension

  • BuildpackConfiguration -> BuildModuleConfiguration
  • BuildpackDependency -> BuildModuleDependency
  • BuildpackDependencyLicense -> BuildModuleDependencyLicense

This allows for extensions to have dependencies and share common code with buildpacks for processing them. Metadata between extensions and buildpacks is common, and although it was possible to mostly process extension metadata without renaming the structs/code, it was rapidly becoming confusing as to which paths supported ONLY buildpacks, and which would support both buildpack and extension usage. This change helps to clarify that by having the common paths now be buildmodule rather than buildpack. (So now, if you see extensions calling into Buildpack stuff, you can expect issues!)

This flows out to the libpak commands that are offered via go, to alter their arg that passed the path to buildpack.toml to be a path to buildpack.toml OR extension.toml

The command changes help pipeline-builder make sense when it's calling a command with an extension rather than a buildpack =)

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@BarDweller BarDweller requested a review from a team as a code owner July 5, 2023 12:37
@BarDweller BarDweller changed the title Release 2.x Updates for Release 2.x (Rename Buildpack to BuildModule for common paths) Jul 5, 2023
@anthonydahanne anthonydahanne added type:enhancement A general enhancement semver:major A change requiring a major version bump labels Jul 5, 2023
Copy link
Member

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonydahanne anthonydahanne merged commit cd68759 into paketo-buildpacks:release-2.x Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major A change requiring a major version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants