Only rely on shasum for dependency cache hit #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #233, like proposed here, let's do this change in the next major update. It is not breaking, but it will change the behaviour in a subtle way. Before, it was possible that the very same dependency was downloaded again.
Summary
When checking if some dependency can be reused, it should be enough to check the
shasum
. There is no need to verify that the metadata is the same (the binary is).Use Cases
This caused cache misses when the metadata was different (e.g.
DeprecationDate
).Checklist