Skip to content

Conversation

GeorgeBekh
Copy link

No description provided.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @GeorgeBekh! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.


You can then start the server with this command:

``python -m pyls``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does just running pyls not work for you?

Copy link
Author

@GeorgeBekh GeorgeBekh Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like it. I install it without sudo so it probably shouldn't work in my case and in general

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make sure pyls is in your path?

Copy link
Author

@GeorgeBekh GeorgeBekh Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because i didn't know where it was located. Now i see that it's in ~/.local/bin/pyls on my system and it's not in my $PATH.

I propose this change because it looks like this method (python -m pyls) is less ambiguous and error-prone. May be i'm wrong so please feel free to correct me

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less error-prone is right. I don't have ~/.local/bin/pyls on my computer. but python -m pyls works. pip show -v python-language-server enabled me to guess that it was in /usr/local/bin, which is in my path.

But I didn't know that command. And had to alias it to "python-language-server" for my editor plugin to find it.

@gatesn
Copy link
Contributor

gatesn commented Feb 15, 2019

I think we fixed this in #344

@gatesn gatesn closed this Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants