Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving some statuses to a config.json instead of an hardcoded approach #28

Merged
merged 6 commits into from
May 14, 2015

Conversation

igorescobar
Copy link

1 - Regarding #27
2 - Fixing extra trailing backslash bug.
3 - Better error handler
4 - Fixing UNABLE_TO_VERIFY_LEAF_SIGNATURE

@germanrcuriel
Copy link
Collaborator

@igorescobar Thanks for the PR, code seems fine to me. I will try to test it before or during the weekend :)

@igorescobar
Copy link
Author

@germanrcuriel Nice! Thanks!

@igorescobar
Copy link
Author

just added another change to fix the #26

@germanrcuriel
Copy link
Collaborator

Tested and working as expected. Thank you :)

germanrcuriel added a commit that referenced this pull request May 14, 2015
Moving some statuses to a config.json instead of an hardcoded approach
@germanrcuriel germanrcuriel merged commit 354d183 into palashkulsh:master May 14, 2015
@igorescobar
Copy link
Author

👍

When the new npm version would be released?

@germanrcuriel
Copy link
Collaborator

I need to test all the things, I've merged 5 PR for this next release. I hope I'll do it during this weekend.

@igorescobar
Copy link
Author

Use https://github.com/kawamanza/step-up to help you with the changelog ;)

@dahlbyk
Copy link

dahlbyk commented May 14, 2015

Fixing extra trailing backslash bug.

Just stumbled on this - glad to see it fixed already. 👏

@igorescobar
Copy link
Author

@dahlbyk thanks ;o)

@dahlbyk dahlbyk mentioned this pull request May 14, 2015
@wkoszek
Copy link

wkoszek commented Aug 13, 2015

Thanks for fixing this issue.

I npm'ed jira-cmd today and it didn't work by default. I had to trim the config.json by hand.

You may want to remove "In Review" from a default config.json, since to me it didn't work either, and we haven't customized JIRA configuration at all, to my knowledge. We use hosted JIRA @ atlassian.net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants