-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving some statuses to a config.json instead of an hardcoded approach #28
Conversation
@igorescobar Thanks for the PR, code seems fine to me. I will try to test it before or during the weekend :) |
@germanrcuriel Nice! Thanks! |
just added another change to fix the #26 |
Tested and working as expected. Thank you :) |
Moving some statuses to a config.json instead of an hardcoded approach
👍 When the new npm version would be released? |
I need to test all the things, I've merged 5 PR for this next release. I hope I'll do it during this weekend. |
Use https://github.com/kawamanza/step-up to help you with the changelog ;) |
Just stumbled on this - glad to see it fixed already. 👏 |
@dahlbyk thanks ;o) |
Thanks for fixing this issue. I npm'ed jira-cmd today and it didn't work by default. I had to trim the config.json by hand. You may want to remove "In Review" from a default config.json, since to me it didn't work either, and we haven't customized JIRA configuration at all, to my knowledge. We use hosted JIRA @ atlassian.net. |
1 - Regarding #27
2 - Fixing extra trailing backslash bug.
3 - Better error handler
4 - Fixing UNABLE_TO_VERIFY_LEAF_SIGNATURE