CLN: Replace FrameOrSeriesUnion annotation by DataFrame | Series

[Swanand01]

• closes STYLE, TYP frame-or-series-union check no longer relevant #40876
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

The FrameOrSeriesUnion check was already removed. I have removed the FrameOrSeriesUnion alias, and replaced all instances of FrameOrSeriesUnion with DataFrame | Series

[MarcoGorelli]

DataFrame | Series doesn't need importing, just remove the FrameOrSeriesUnion import :)

[Swanand01]

Should I remove all other places where DataFrame | Series is being imported as well?

[MarcoGorelli]

yeah, from pandas._typing import DataFrame | Series is invalid syntax anyway

[Swanand01]

HI, I have created a new commit. Please review it. Thank you.

[MarcoGorelli]

HI, I have created a new commit. Please review it. Thank you.

Thanks - can you fetch and merge upstream/master please?

[Swanand01]

Hi @MarcoGorelli, I seem to be stuck. I updated the forked repo on my github page by fetch and merge upstream, and tried to push changes. However, I cannot see the Compare and Pull Request button that usually appears. Initially, I tried force pushing as git would not let me push changes. Thanks.

[MarcoGorelli]

I cannot see the Compare and Pull Request button that usually appears

If you've already opened a pull request (as you have), there's no need to open a new one, you can just add a commit and push it

[MarcoGorelli]

Looks like there's a merge conflict, could you resolve it please?

My workflow for doing this would be

git fetch upstream
git merge upstream/master
# resolve any conflicts
git commit -a
git push origin

[pep8speaks]

Hello @Swanand01! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-11 17:30:30 UTC