Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: In HDFStore create warnings for mode, quiet #4367

Closed
jreback opened this issue Jul 25, 2013 · 5 comments · Fixed by #4417

Comments

@jreback
Copy link
Contributor

commented Jul 25, 2013

  • If mode == 'w' and warn==True then weird raw_input is requested. Change this to raise/warn as appropriate
  • change the _quiet field (default is False) to a warning (about duplicates in readback)
@jtratner

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2013

When I was looking at this before, was thinking that store could change mode from w after opening so that it doesn't overwrite on a second write. (i.e., at end of the handle open part, just change mode to whatever seems appropriate - user can change mode explicitly if they want...)

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2013

I always open as append mode (personally)

I simulate w by removing the file

I think that might be the way to go here

then u don't need to track status of the mode

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2013

@jtratner changed the API slightly on open/closes....let me know if you think it makes sens

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2013

I think I proposed it but then never got to it, because I wasn't sure what real-world uses would do.

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2013

heh, so what I proposed is actually at the top of this issue 😝

@jreback jreback closed this in #4417 Aug 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.