TST: Assist Replace ensure_clean utility function with the temp_file pytest fixture #62435 #62461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_return_result_expected updated to temp file fixture
fix missed temp file
pandeconscious
changed the title
pandeconscious
changed the title
pandeconscious
changed the title
pandeconscious
changed the title
mroeschke
requested changes
Sep 29, 2025
| with tm.ensure_clean("__tmp_to_csv_moar__") as path: | ||
| df.to_csv(path, encoding="utf8", chunksize=chunksize) | ||
| recons = self.read_csv(path, **kwargs) | ||
| path = str(temp_file) |
There was a problem hiding this comment.
Generally, could you try using temp_file as an argument instead of converting to a string when doing these modifications, unless the test appears to explicitly be testing a string argument?
There was a problem hiding this comment.
fixed in the next set of changes, will be ready for review once tests are successful
mroeschke
added
the
Testing
mroeschke
approved these changes
Oct 1, 2025
|
Thanks @pandeconscious |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 1, 2025
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_cleanutility function with thetemp_filepytest fixture #62435 as part of a larger effortTests added and passed if fixing a bug or adding a new featureAdded type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.