Fix PR10 error and Clean up docstrings from functions related to RT05 errors #25132

thoo · 2019-02-04T04:00:34Z

~~closes Fix validation error type RT05 and check in CI #25108~~ Related to Fix validation error type RT05 and check in CI #25108 ,DOC: Fixes to docstrings and add PR10 (space before colon) to validation #25109
tests added / passed (./scripts/validate_docstrings.py --errors=RT05)
passes git diff upstream/master -u -- "*.py" | flake8 --diff

pep8speaks · 2019-02-04T04:00:52Z

Hello @thoo! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 28, 2019 at 01:28 Hours UTC

codecov · 2019-02-04T04:35:24Z

Codecov Report

Merging #25132 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25132   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52408    52408           
=======================================
  Hits        48411    48411           
  Misses       3997     3997

Flag	Coverage Δ
#multiple	`90.79% <ø> (ø)`	⬆️
#single	`42.86% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/tools/numeric.py	`100% <ø> (ø)`	⬆️
pandas/core/arrays/datetimelike.py	`97.67% <ø> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.6% <ø> (ø)`	⬆️
pandas/core/series.py	`93.68% <ø> (ø)`	⬆️
pandas/core/panel.py	`97.91% <ø> (ø)`	⬆️
pandas/tseries/frequencies.py	`97.7% <ø> (ø)`	⬆️
pandas/core/frame.py	`96.81% <ø> (ø)`	⬆️
pandas/io/formats/style.py	`96.69% <ø> (ø)`	⬆️
pandas/core/generic.py	`96.63% <ø> (ø)`	⬆️
pandas/plotting/_core.py	`83.58% <ø> (ø)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c9d6e...2c4455c. Read the comment docs.

codecov · 2019-02-04T04:35:35Z

Codecov Report

Merging #25132 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #25132      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         173      173              
  Lines       52923    52923              
==========================================
- Hits        48555    48554       -1     
- Misses       4368     4369       +1

Flag	Coverage Δ
#multiple	`90.31% <100%> (ø)`	⬆️
#single	`41.73% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	`97.67% <ø> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.62% <ø> (ø)`	⬆️
pandas/core/series.py	`93.68% <ø> (ø)`	⬆️
pandas/tseries/frequencies.py	`97.7% <ø> (ø)`	⬆️
pandas/core/frame.py	`96.85% <ø> (ø)`	⬆️
pandas/core/generic.py	`94.16% <ø> (ø)`	⬆️
pandas/core/algorithms.py	`94.77% <ø> (ø)`	⬆️
pandas/plotting/_misc.py	`38.68% <ø> (ø)`	⬆️
pandas/core/arrays/categorical.py	`95.97% <ø> (ø)`	⬆️
pandas/io/excel/_base.py	`92.48% <ø> (ø)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c986386...2d62018. Read the comment docs.

jreback · 2019-02-04T12:57:07Z

can you merge master. RT04 is now active, so I think you need to adjust some things.

* upstream/master: TST/REF: collect DataFrame reduction tests (pandas-dev#24914) DOC: Improve docstring of Series.mul (pandas-dev#25136) Removal of return variable names (pandas-dev#25123) BUG: Fixing regression in DataFrame.all and DataFrame.any with bool_only=True (pandas-dev#25102) Reading a HDF5 created in py2 (pandas-dev#25058) DOC: Fix validation type error RT04 (pandas-dev#25107) (pandas-dev#25129)

pandas/core/generic.py

* upstream/master: Fix validation error type `SS05` and check in CI (pandas-dev#25133)

datapythonista

Looks good, some special cases can probably be improved

ci/code_checks.sh

pandas/core/algorithms.py

pandas/core/arrays/categorical.py

pandas/core/arrays/datetimelike.py

pandas/plotting/_core.py

pandas/plotting/_misc.py

pandas/tseries/frequencies.py

* upstream/master: DOC: Fix validation type error SA05 (pandas-dev#25208) REF: Add more pytest idiom to test_holiday.py (pandas-dev#25204) DOC/CLN: Fix errors in Series docstrings (pandas-dev#24945) TST: follow-up to Test nested pandas array pandas-dev#24993 (pandas-dev#25155) modernize compat imports (pandas-dev#25192) fix MacPython pandas-wheels failure (pandas-dev#25186) BUG: DataFrame.merge(suffixes=) does not respect None (pandas-dev#24819) DEPR: remove PanelGroupBy, disable DataFrame.to_panel (pandas-dev#25047) DOC: update docstring for series.nunique (pandas-dev#25116) CLN: Use ABCs in set_index (pandas-dev#25128) BLD: pin cython language level to '2' (pandas-dev#25145) DOC: Updates to Timestamp document (pandas-dev#25163) STY: use pytest.raises context manager (indexes/multi) (pandas-dev#25175) Fixed tuple to List Conversion in Dataframe class (pandas-dev#25089)

* upstream/master: fix ci failures (pandas-dev#25225) STY: use pytest.raises context manager (indexes/period) (pandas-dev#25199) DOC: exclude autogenerated c/cpp/html files from 'trailing whitespace' checks (pandas-dev#24549) DOC: Fixes to docstrings and add PR10 (space before colon) to validation (pandas-dev#25109) REF: Remove many Panel tests (pandas-dev#25191) BUG: Fix Series.is_unique with single occurrence of NaN (pandas-dev#25182)

jreback · 2019-02-09T17:43:55Z

@datapythonista if you'd re-look. merge when good.

* upstream/master: BUG: Fix exceptions when Series.interpolate's `order` parameter is missing or invalid (pandas-dev#25246) API: Ensure DatetimeTZDtype standardizes pytz timezones (pandas-dev#25254) Split Excel IO Into Sub-Directory (pandas-dev#25153) PR04 errors fix (pandas-dev#25157) DEPR: remove assert_panel_equal (pandas-dev#25238) BUG: pandas Timestamp tz_localize and tz_convert do not preserve `freq` attribute (pandas-dev#25247) Revert "BLD: prevent asv from calling sys.stdin.close() by using different launch method (pandas-dev#25237)" (pandas-dev#25253) REF/TST: resample/test_base.py (pandas-dev#25262) BUG: Duplicated returns boolean dataframe (pandas-dev#25234) CLN: Remove ipython 2.x compat (pandas-dev#25150) Refactor groupby group_add from tempita to fused types (pandas-dev#24954) CLN: For loops, boolean conditions, misc. (pandas-dev#25206) (Closes pandas-dev#25029) Removed extra bracket from cheatsheet code example. (pandas-dev#25032) BLD: prevent asv from calling sys.stdin.close() by using different launch method (pandas-dev#25237) BUG: Fix read_json orient='table' without index (pandas-dev#25170) (pandas-dev#25171) BUG: Fix regression in DataFrame.apply causing RecursionError (pandas-dev#25230) BUG-25061 fix printing indices with NaNs (pandas-dev#25202) DEPR: Add Deprecated warning for timedelta with passed units M and Y (pandas-dev#23264) DEPR: Remove Panel-specific parts of io.pytables (pandas-dev#25233) DEPR: remove tm.makePanel and all usages (pandas-dev#25231)

datapythonista

Great job, thanks for all the fixes. Just few comments.

datapythonista · 2019-02-13T17:16:59Z

pandas/core/algorithms.py

-      If the input is an Index, the return is an Index
-      If the input is a Categorical dtype, the return is a Categorical
-      If the input is a Series/ndarray, the return will be an ndarray
+    unique values


This should be the type, can you find out what's the returned Python type, and move this to the description please?

datapythonista · 2019-02-13T17:17:34Z

pandas/core/arrays/categorical.py

@@ -1292,7 +1292,7 @@ def __array__(self, dtype=None):
        values : numpy array


Suggested change

values : numpy array

numpy.array

datapythonista · 2019-02-13T17:17:44Z

pandas/core/arrays/categorical.py

@@ -1501,7 +1501,7 @@ def get_values(self):
        -------
        values : numpy array


Suggested change

values : numpy array

numpy.array

datapythonista · 2019-02-13T17:18:09Z

pandas/core/frame.py

@@ -2696,7 +2696,7 @@ def get_value(self, index, col, takeable=False):

        Returns
        -------
-        value : scalar value
+        scalar value


Suggested change

scalar value

scalar

datapythonista · 2019-02-13T17:18:22Z

pandas/core/frame.py

@@ -3542,7 +3542,7 @@ def _sanitize_column(self, key, value, broadcast=True):

        Returns
        -------
-        sanitized_column : numpy-array
+        numpy-array


Suggested change

numpy-array

numpy.array

datapythonista · 2019-02-13T17:25:58Z

pandas/plotting/_core.py

@@ -3238,7 +3239,7 @@ def hist(self, by=None, bins=10, **kwds):

        Returns
        -------
-        axes : matplotlib.AxesSubplot histogram.
+        matplotlib.AxesSubplot histogram.


Leave just the type, say it's a Histogram in the description.

datapythonista · 2019-02-13T17:26:49Z

pandas/plotting/_misc.py

@@ -302,7 +302,7 @@ def andrews_curves(frame, class_column, ax=None, samples=200, color=None,

    Returns
    -------
-    ax : Matplotlib axis object
+    Matplotlib axis object


Suggested change

Matplotlib axis object

class:`matplotlib.axes.Axes`

There are many like this afterwards

datapythonista · 2019-02-13T17:26:57Z

pandas/plotting/_misc.py

@@ -490,7 +490,7 @@ def parallel_coordinates(frame, class_column, cols=None, ax=None, color=None,

    Returns
    -------
-    ax: matplotlib axis object
+    matplotlib axis object


Suggested change

matplotlib axis object

class:`matplotlib.axes.Axes`

datapythonista · 2019-02-13T17:27:02Z

pandas/plotting/_misc.py

@@ -579,7 +579,7 @@ def lag_plot(series, lag=1, ax=None, **kwds):

    Returns
    -------
-    ax: Matplotlib axis object
+    Matplotlib axis object


Suggested change

Matplotlib axis object

class:`matplotlib.axes.Axes`

datapythonista · 2019-02-13T17:27:07Z

pandas/plotting/_misc.py

@@ -610,7 +610,7 @@ def autocorrelation_plot(series, ax=None, **kwds):

    Returns:
    -----------
-    ax: Matplotlib axis object
+    Matplotlib axis object


Suggested change

Matplotlib axis object

class:`matplotlib.axes.Axes`

thoo · 2019-02-14T19:38:49Z

@datapythonista I think #25108 is already closed by #25309. Should I fix with your suggestions which are not covered by #25309? Or just close this PR and submit the new one?

WillAyd · 2019-02-14T19:42:06Z

@thoo sorry didn't realize we had two PRs for this and other is already merged for RT05. Are there other elements to this outside of that you are trying to merge?

jreback · 2019-02-17T17:27:37Z

pls merge master again

* upstream/master: TST: xfail excel styler tests, xref GH25351 (pandas-dev#25352)

jreback · 2019-02-19T14:05:37Z

cc @datapythonista

datapythonista

lgtm, thanks @thoo

WillAyd · 2019-02-20T15:41:47Z

ci/code_checks.sh

@@ -241,8 +241,8 @@ fi
 ### DOCSTRINGS ###
 if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then

-    MSG='Validate docstrings (GL06, GL07, GL09, SS04, PR03, PR05, PR10, EX04, RT04, RT05, SS05, SA05)' ; echo $MSG
-    $BASE_DIR/scripts/validate_docstrings.py --format=azure --errors=GL06,GL07,GL09,SS04,PR03,PR04,PR05,EX04,RT04,RT05,SS05,SA05
+    MSG='Validate docstrings (GL06, GL07, GL09, SS04, SS05, PR03, PR04, PR05, EX04, RT04, RT05, SA05)' ; echo $MSG


Was there a reason for removing PR10 here or just mistake?

~~It is just a mistake from merge.~~

PR10 is actually not included in the current check at line 245. So I wasn't sure someone exclude PR10 but forgot to remove from the message.

Good catch. I think this was just missed in #25109 so makes sense to update here accordingly

##[error]pandas/io/excel/_base.py(492,): error PR10: pandas.ExcelWriter: Parameter ".. versionadded" requires a space before the colon separating the parameter name and type

~~PR10 is not passing the check with .. versionadded:: 0.24.. I am going to leave PR10 for now.~~ Update pandas.ExcelWriter

WillAyd · 2019-02-20T15:43:53Z

pandas/core/series.py

@@ -1629,7 +1629,7 @@ def unique(self):
            * Datetime with Timezone
            * Interval
            * Sparse
-            * IntegerNA
+            * IntegerNA .


I've seen this on quite a few other requests. Nuanced but I'm personally of the opinion that this is a "hack" to pass validation so would prefer another route. Can you just add a one-line description after the bullet points instead?

pandas/core/generic.py

* upstream/master: API: more consistent error message for MultiIndex.from_arrays (pandas-dev#25189) fix typo of see also in DataFrame stat funcs (pandas-dev#25388) edited whatsnew typo (pandas-dev#25381) REGR: fix TimedeltaIndex sum and datetime subtraction with NaT (pandas-dev#25282, pandas-dev#25317) (pandas-dev#25329) ENH: indexing and __getitem__ of dataframe and series accept zerodim integer np.array as int (pandas-dev#24924) [CLN] Excel Module Cleanups (pandas-dev#25275) Interval dtype fix (pandas-dev#25338) BUG/ENH: Timestamp.strptime (pandas-dev#25124) 14873: test for groupby.agg coercing booleans (pandas-dev#25327) [BUG] exception handling of MultiIndex.__contains__ too narrow (pandas-dev#25268) 9236: test for the DataFrame.groupby with MultiIndex having pd.NaT (pandas-dev#25310) pandas-dev#23049: test for Fatal Stack Overflow stemming From Misuse of astype('category') (pandas-dev#25366) Remove spurious MultiIndex creation in `_set_axis_name` (pandas-dev#25371) DOC: modify typos in Contributing section (pandas-dev#25365) DOC/BLD: fix --no-api option (pandas-dev#25209) DOC: Correct doc mistake in combiner func (pandas-dev#25360)

WillAyd · 2019-02-21T02:29:59Z

@thoo looking pretty good thanks for addressing comments. Can you update title to reflect what this PR is actually addressing, since it's no longer RT05?

WillAyd

Minor things but otherwise lgtm and thanks for updating title.

@datapythonista - some changes since your last approval do you mind taking a look again?

pandas/core/generic.py

WillAyd · 2019-02-21T16:49:35Z

pandas/core/generic.py

+        - If DataFrame.agg is called with several functions, returns
+          a DataFrame.
+        - If Series.agg is called with single function, returns a scalar.
+        - If Series.agg is called with several functions, returns a Series.


Let's do the same thing you are doing below, where instead of putting periods at the end of each bullet you end with a short sentence after the bullets

WillAyd · 2019-02-21T16:49:55Z

pandas/core/algorithms.py

+
+        - If the input is an Index, the return is an Index.
+        - If the input is a Categorical dtype, the return is a Categorical.
+        - If the input is a Series/ndarray, the return will be an ndarray.


Same comment here around periods for bullet points

datapythonista

looks good, jut couple of comments more besides the ones already mentioned

datapythonista · 2019-02-21T17:02:32Z

pandas/core/indexes/base.py

            indexer is an ndarray or None if cannot convert
-            keyarr are tuple-safe keys
+            keyarr are tuple-safe keys.


do you mind documenting both parameters separately? It's done in other parts of this PR

pandas/core/series.py

datapythonista · 2019-02-21T17:03:38Z

pandas/io/excel/_base.py

-        File mode to use (write or append).
-
-    .. versionadded:: 0.24.0
+        File mode to use (write or append). .. versionadded:: 0.24.0


is there a reason for this? Not sure if this will render correctly in the html

Yeah, that's right. I was about to fix it.

* upstream/master: CLN: (re-)enable infer_dtype to catch complex (pandas-dev#25382)

datapythonista

All good, just the Returns with the creative documenting of multiple values needs to be fixed

datapythonista · 2019-02-22T10:15:42Z

pandas/core/indexes/base.py

+            - indexer : an ndarray or None if cannot convert
+            - keyarr : tuple-safe keys
+
+            Return indexer, keyarr.


Can you check in this diff the previous change? That's how a Return with multiple values is documented.

WillAyd · 2019-02-27T23:24:18Z

@thoo can you merge master and ping on green?

* upstream/master: DOC: CategoricalIndex doc string (pandas-dev#24852) CI: add __init__.py to isort skip list (pandas-dev#25455) TST: numpy RuntimeWarning with Series.round() (pandas-dev#25432) DOC: fixed geo accessor example in extending.rst (pandas-dev#25420) BUG: fixed merging with empty frame containing an Int64 column (pandas-dev#25183) (pandas-dev#25289) TST: remove never-used singleton fixtures (pandas-dev#24885) PERF/REF: improve performance of Series.searchsorted, PandasArray.searchsorted, collect functionality (pandas-dev#22034) BUG: Indexing with UTC offset string no longer ignored (pandas-dev#25263) API/ERR: allow iterators in df.set_index & improve errors (pandas-dev#24984) DOC: Rewriting of ParserError doc + minor spacing (pandas-dev#25421) ENH: Add in sort keyword to DatetimeIndex.union (pandas-dev#25110) ERR: doc update for ParsingError (pandas-dev#25414) BUG: Fix type coercion in read_json orient='table' (pandas-dev#21345) (pandas-dev#25219) DEP: add pytest-mock to environment.yml (pandas-dev#25417) Correct a typo of version number for interpolate() (pandas-dev#25418) Mark test_pct_max_many_rows as high memory (pandas-dev#25400) DOC: Edited docstring of Interval (pandas-dev#25410)

thoo · 2019-03-01T01:31:53Z

@WillAyd All checks passed.

WillAyd · 2019-03-01T01:46:54Z

Thanks @thoo !

* ERR/TST: Add pytest idiom to dtypes/test_cast.py (pandas-dev#24847) * fix MacPython pandas-wheels failue (pandas-dev#24851) * DEPS: Bump pyarrow min version to 0.9.0 (pandas-dev#24854) Closes pandas-devgh-24767 * DOC: Document AttributeError for accessor (pandas-dev#24855) Closes pandas-dev#20579 * Start whatsnew for 0.24.1 and 0.25.0 (pandas-dev#24848) * DEPR/API: Non-ns precision in Index constructors (pandas-dev#24806) * BUG: Format mismatch doesn't coerce to NaT (pandas-dev#24815) * BUG: Properly parse unicode usecols names in CSV (pandas-dev#24856) * CLN: fix typo in asv eval.Query suite (pandas-dev#24865) * BUG: DataFrame respects dtype with masked recarray (pandas-dev#24874) * REF/CLN: Move private method (pandas-dev#24875) * BUG : ValueError in case on NaN value in groupby columns (pandas-dev#24850) * BUG: fix floating precision formatting in presence of inf (pandas-dev#24863) * DOC: Creating top-level user guide section, and moving pages inside (pandas-dev#24677) * DOC: Creating top-level development section, and moving pages inside (pandas-dev#24691) * DOC: Creating top-level getting started section, and moving pages inside (pandas-dev#24678) * DOC: Implementing redirect system, and adding user_guide redirects (pandas-dev#24715) * DOC: Implementing redirect system, and adding user_guide redirects * Using relative urls for the redirect * Validating that no file is overwritten by a redirect * Adding redirects for getting started and development sections * DOC: fixups (pandas-dev#24888) * Fixed heading on whatnew * Remove empty scalars.rst * CLN: fix typo in ctors.SeriesDtypesConstructors setup (pandas-dev#24894) * DOC: No clean in sphinx_build (pandas-dev#24902) Closes pandas-dev#24727 * BUG (output formatting): use fixed with for truncation column instead of inferring from last column (pandas-dev#24905) * DOC: also redirect old whatsnew url (pandas-dev#24906) * Revert BUG-24212 fix usage of Index.take in pd.merge (pandas-dev#24904) * Revert BUG-24212 fix usage of Index.take in pd.merge xref pandas-dev#24733 xref pandas-dev#24897 * test 0.23.4 output * added note about buggy test * DOC: Add experimental note to DatetimeArray and TimedeltaArray (pandas-dev#24882) * DOC: Add experimental note to DatetimeArray and TimedeltaArray * Disable M8 in nanops (pandas-dev#24907) * Disable M8 in nanops Closes pandas-dev#24752 * CLN: fix typo in asv benchmark of non_unique_sorted, which was not sorted (pandas-dev#24917) * API/VIS: remove misc plotting methods from plot accessor (revert pandas-dev#23811) (pandas-dev#24912) * DOC: some 0.24.0 whatsnew clean-up (pandas-dev#24911) * DOC: Final reorganization of documentation pages (pandas-dev#24890) * DOC: Final reorganization of documentation pages * Move ecosystem to top level * DOC: Adding redirects to API moved pages (pandas-dev#24909) * DOC: Adding redirects to API moved pages * DOC: Making home page links more compact and clearer (pandas-dev#24928) * DOC: 0.24 release date (pandas-dev#24930) * DOC: Adding version to the whatsnew section in the home page (pandas-dev#24929) * API: Remove IntervalArray from top-level (pandas-dev#24926) * RLS: 0.24.0 * DEV: Start 0.25 cycle * DOC: State that we support scalars in to_numeric (pandas-dev#24944) We support it and test it already. xref pandas-devgh-24910. * DOC: Minor what's new fix (pandas-dev#24933) * TST: GH#23922 Add missing match params to pytest.raises (pandas-dev#24937) * Add tests for NaT when performing dt.to_period (pandas-dev#24921) * DOC: switch headline whatsnew to 0.25 (pandas-dev#24941) * BUG-24212 fix regression in pandas-dev#24897 (pandas-dev#24916) * CLN: reduce overhead in setup for categoricals benchmarks in asv (pandas-dev#24913) * Excel Reader Refactor - Base Class Introduction (pandas-dev#24829) * TST/REF: Add pytest idiom to test_numeric.py (pandas-dev#24946) * BLD: silence npy_no_deprecated warnings with numpy>=1.16.0 (pandas-dev#24864) * CLN: Refactor cython to use memory views (pandas-dev#24932) * DOC: Clean sort_values and sort_index docstrings (pandas-dev#24843) * STY: use pytest.raises context syntax (indexing) (pandas-dev#24960) * Fixed itertuples usage in to_dict (pandas-dev#24965) * Fixed itertuples usage in to_dict Closes pandas-dev#24940 Closes pandas-dev#24939 * STY: use pytest.raises context manager (resample) (pandas-dev#24977) * DOC: Document breaking change to read_csv (pandas-dev#24989) * DEPR: Fixed warning for implicit registration (pandas-dev#24964) * STY: use pytest.raises context manager (indexes/datetimes) (pandas-dev#24995) * DOC: move whatsnew note of pandas-dev#24916 (pandas-dev#24999) * BUG: Fix broken links (pandas-dev#25002) The previous location of contributing.rst file was /doc/source/contributing.rst but has been moved to /doc/source/development/contributing.rst * fix for BUG: grouping with tz-aware: Values falls after last bin (pandas-dev#24973) * REGR: Preserve order by default in Index.difference (pandas-dev#24967) Closes pandas-dev#24959 * CLN: do not use .repeat asv setting for storing benchmark data (pandas-dev#25015) * CLN: isort asv_bench/benchmark/algorithms.py (pandas-dev#24958) * fix+test to_timedelta('NaT', box=False) (pandas-dev#24961) * PERF: significant speedup in sparse init and ops by using numpy in check_integrity (pandas-dev#24985) * BUG: Fixed merging on tz-aware (pandas-dev#25033) * Test nested PandasArray (pandas-dev#24993) * DOC: fix error in documentation pandas-dev#24981 (pandas-dev#25038) * BUG: support dtypes in column_dtypes for to_records() (pandas-dev#24895) * Makes example from docstring work (pandas-dev#25035) * CLN: typo fixups (pandas-dev#25028) * BUG: to_datetime(strs, utc=True) used previous UTC offset (pandas-dev#25020) * BUG: Better handle larger numbers in to_numeric (pandas-dev#24956) * BUG: Better handle larger numbers in to_numeric * Warn about lossiness when passing really large numbers that exceed (u)int64 ranges. * Coerce negative numbers to float when requested instead of crashing and returning object. * Consistently parse numbers as integers / floats, even if we know that the resulting container has to be float. This is to ensure consistent error behavior when inputs numbers are too large. Closes pandas-devgh-24910. * MAINT: Address comments * BUG: avoid usage in_qtconsole for recent IPython versions (pandas-dev#25039) * Drop IPython<4.0 compat * Revert "Drop IPython<4.0 compat" This reverts commit 0cb0452. * update a * whatsnew * REGR: fix read_sql delegation for queries on MySQL/pymysql (pandas-dev#25024) * DOC: Start 0.24.2.rst (pandas-dev#25026) [ci skip] * REGR: rename_axis with None should remove axis name (pandas-dev#25069) * clarified the documentation for DF.drop_duplicates (pandas-dev#25056) * Clarification in docstring of Series.value_counts (pandas-dev#25062) * ENH: Support fold argument in Timestamp.replace (pandas-dev#25046) * CLN: to_pickle internals (pandas-dev#25044) * Implement+Test Tick.__rtruediv__ (pandas-dev#24832) * API: change Index set ops sort=True -> sort=None (pandas-dev#25063) * BUG: to_clipboard text truncated for Python 3 on Windows for UTF-16 text (pandas-dev#25040) * PERF: use new to_records() argument in to_stata() (pandas-dev#25045) * DOC: Cleanup 0.24.1 whatsnew (pandas-dev#25084) * Fix quotes position in pandas.core, typos and misspelled parameters. (pandas-dev#25093) * CLN: Remove sentinel_factory() in favor of object() (pandas-dev#25074) * TST: remove DST transition scenarios from tc pandas-dev#24689 (pandas-dev#24736) * BLD: remove spellcheck from Makefile (pandas-dev#25111) * DOC: small clean-up of 0.24.1 whatsnew (pandas-dev#25096) * DOC: small doc fix to Series.repeat (pandas-dev#25115) * TST: tests for categorical apply (pandas-dev#25095) * CLN: use dtype in constructor (pandas-dev#25098) * DOC: frame.py doctest fixing (pandas-dev#25097) * DOC: 0.24.1 release (pandas-dev#25125) [ci skip] * Revert set_index inspection/error handling for 0.24.1 (pandas-dev#25085) * DOC: Minor what's new fix (pandas-dev#24933) * Backport PR pandas-dev#24916: BUG-24212 fix regression in pandas-dev#24897 (pandas-dev#24951) * Revert "Backport PR pandas-dev#24916: BUG-24212 fix regression in pandas-dev#24897 (pandas-dev#24951)" This reverts commit 84056c5. * DOC/CLN: Timezone section in timeseries.rst (pandas-dev#24825) * DOC: Improve timezone documentation in timeseries.rst * edit some of the examples * Address review * DOC: Fix validation type error RT04 (pandas-dev#25107) (pandas-dev#25129) * Reading a HDF5 created in py2 (pandas-dev#25058) * BUG: Fixing regression in DataFrame.all and DataFrame.any with bool_only=True (pandas-dev#25102) * Removal of return variable names (pandas-dev#25123) * DOC: Improve docstring of Series.mul (pandas-dev#25136) * TST/REF: collect DataFrame reduction tests (pandas-dev#24914) * Fix validation error type `SS05` and check in CI (pandas-dev#25133) * Fixed tuple to List Conversion in Dataframe class (pandas-dev#25089) * STY: use pytest.raises context manager (indexes/multi) (pandas-dev#25175) * DOC: Updates to Timestamp document (pandas-dev#25163) * BLD: pin cython language level to '2' (pandas-dev#25145) Not explicitly pinning the language level has been producing future warnings from cython. The next release of cython is going to change the default level to '3str' under which the pandas cython extensions do not compile. The long term solution is to update the cython files to the next language level, but this is a stop-gap to keep pandas building. * CLN: Use ABCs in set_index (pandas-dev#25128) * DOC: update docstring for series.nunique (pandas-dev#25116) * DEPR: remove PanelGroupBy, disable DataFrame.to_panel (pandas-dev#25047) * BUG: DataFrame.merge(suffixes=) does not respect None (pandas-dev#24819) * fix MacPython pandas-wheels failure (pandas-dev#25186) * modernize compat imports (pandas-dev#25192) * TST: follow-up to Test nested pandas array pandas-dev#24993 (pandas-dev#25155) * revert changes to tests in pandas-devgh-24993 * Test nested PandasArray * isort test_numpy.py * change NP_VERSION_INFO * use LooseVersion * add _np_version_under1p16 * remove blank line from merge master * add doctstrings to fixtures * DOC/CLN: Fix errors in Series docstrings (pandas-dev#24945) * REF: Add more pytest idiom to test_holiday.py (pandas-dev#25204) * DOC: Fix validation type error SA05 (pandas-dev#25208) Create check for SA05 errors in CI * BUG: Fix Series.is_unique with single occurrence of NaN (pandas-dev#25182) * REF: Remove many Panel tests (pandas-dev#25191) * DOC: Fixes to docstrings and add PR10 (space before colon) to validation (pandas-dev#25109) * DOC: exclude autogenerated c/cpp/html files from 'trailing whitespace' checks (pandas-dev#24549) * STY: use pytest.raises context manager (indexes/period) (pandas-dev#25199) * fix ci failures (pandas-dev#25225) * DEPR: remove tm.makePanel and all usages (pandas-dev#25231) * DEPR: Remove Panel-specific parts of io.pytables (pandas-dev#25233) * DEPR: Add Deprecated warning for timedelta with passed units M and Y (pandas-dev#23264) * BUG-25061 fix printing indices with NaNs (pandas-dev#25202) * BUG: Fix regression in DataFrame.apply causing RecursionError (pandas-dev#25230) * BUG: Fix regression in DataFrame.apply causing RecursionError * Add feedback from PR * Add feedback after further code review * Add feedback after further code review 2 * BUG: Fix read_json orient='table' without index (pandas-dev#25170) (pandas-dev#25171) * BLD: prevent asv from calling sys.stdin.close() by using different launch method (pandas-dev#25237) * (Closes pandas-dev#25029) Removed extra bracket from cheatsheet code example. (pandas-dev#25032) * CLN: For loops, boolean conditions, misc. (pandas-dev#25206) * Refactor groupby group_add from tempita to fused types (pandas-dev#24954) * CLN: Remove ipython 2.x compat (pandas-dev#25150) * CLN: Remove ipython 2.x compat * trivial change to trigger asv * Update v0.25.0.rst * revert whatsnew * BUG: Duplicated returns boolean dataframe (pandas-dev#25234) * REF/TST: resample/test_base.py (pandas-dev#25262) * Revert "BLD: prevent asv from calling sys.stdin.close() by using different launch method (pandas-dev#25237)" (pandas-dev#25253) This reverts commit f67b7fd. * BUG: pandas Timestamp tz_localize and tz_convert do not preserve `freq` attribute (pandas-dev#25247) * DEPR: remove assert_panel_equal (pandas-dev#25238) * PR04 errors fix (pandas-dev#25157) * Split Excel IO Into Sub-Directory (pandas-dev#25153) * API: Ensure DatetimeTZDtype standardizes pytz timezones (pandas-dev#25254) * API: Ensure DatetimeTZDtype standardizes pytz timezones * Add whatsnew * BUG: Fix exceptions when Series.interpolate's `order` parameter is missing or invalid (pandas-dev#25246) * BUG: raise accurate exception from Series.interpolate (pandas-dev#24014) * Actually validate `order` before use in spline * Remove unnecessary check and dead code * Clean up comparison/tests based on feedback * Include invalid order value in exception * Check for NaN order in spline validation * Add whatsnew entry for bug fix * CLN: Make unit tests assert one error at a time * CLN: break test into distinct test case * PEP8 fix in test module * CLN: Test fixture for interpolate methods * BUG: DataFrame.join on tz-aware DatetimeIndex (pandas-dev#25260) * REF: use _constructor and ABCFoo to avoid runtime imports (pandas-dev#25272) * Refactor groupby group_prod, group_var, group_mean, group_ohlc (pandas-dev#25249) * Fix typo in Cheat sheet with regex (pandas-dev#25215) * Edit parameter type in pandas.core.frame.py DataFrame.count (pandas-dev#25198) * TST/CLN: remove test_slice_ints_with_floats_raises (pandas-dev#25277) * Removed Panel class from HDF ASVs (pandas-dev#25281) * DOC: Fix minor typo in docstring (pandas-dev#25285) * DOC/CLN: Fix errors in DataFrame docstrings (pandas-dev#24952) * Skipped broken Py2 / Windows test (pandas-dev#25323) * Rt05 documentation error fix issue 25108 (pandas-dev#25309) * Fix typos in docs (pandas-dev#25305) * Doc: corrects spelling in generic.py (pandas-dev#25333) * BUG: groupby.transform retains timezone information (pandas-dev#25264) * Fixes Formatting Exception (pandas-dev#25088) * Bug: OverflowError in resample.agg with tz data (pandas-dev#25297) * DOC/CLN: Fix various docstring errors (pandas-dev#25295) * COMPAT: alias .to_numpy() for timestamp and timedelta scalars (pandas-dev#25142) * ENH: Support times with timezones in at_time (pandas-dev#25280) * BUG: Fix passing of numeric_only argument for categorical reduce (pandas-dev#25304) * TST: use a fixed seed to have the same uniques across python versions (pandas-dev#25346) TST: add pytest-mock to handle mocker fixture * TST: xfail excel styler tests, xref GH25351 (pandas-dev#25352) * TST: xfail excel styler tests, xref GH25351 * CI: cleanup .c files for cpplint>1.4 * DOC: Correct doc mistake in combiner func (pandas-dev#25360) Closes pandas-devgh-25359. * DOC/BLD: fix --no-api option (pandas-dev#25209) * DOC: modify typos in Contributing section (pandas-dev#25365) * Remove spurious MultiIndex creation in `_set_axis_name` (pandas-dev#25371) * Resovles pandas-dev#25370 * Introduced by pandas-dev#22969 * pandas-dev#23049: test for Fatal Stack Overflow stemming From Misuse of astype('category') (pandas-dev#25366) * 9236: test for the DataFrame.groupby with MultiIndex having pd.NaT (pandas-dev#25310) * [BUG] exception handling of MultiIndex.__contains__ too narrow (pandas-dev#25268) * 14873: test for groupby.agg coercing booleans (pandas-dev#25327) * BUG/ENH: Timestamp.strptime (pandas-dev#25124) * BUG: constructor Timestamp.strptime() does not support %z. * Add doc string to NaT and Timestamp * updated the error message * Updated whatsnew entry. * Interval dtype fix (pandas-dev#25338) * [CLN] Excel Module Cleanups (pandas-dev#25275) Closes pandas-devgh-25153 Authored-By: tdamsma <tdamsma@gmail.com> * ENH: indexing and __getitem__ of dataframe and series accept zerodim integer np.array as int (pandas-dev#24924) * REGR: fix TimedeltaIndex sum and datetime subtraction with NaT (pandas-dev#25282, pandas-dev#25317) (pandas-dev#25329) * edited whatsnew typo (pandas-dev#25381) * fix typo of see also in DataFrame stat funcs (pandas-dev#25388) * API: more consistent error message for MultiIndex.from_arrays (pandas-dev#25189) * CLN: (re-)enable infer_dtype to catch complex (pandas-dev#25382) * DOC: Edited docstring of Interval (pandas-dev#25410) The docstring contained a repeated segment, which I removed. * Mark test_pct_max_many_rows as high memory (pandas-dev#25400) Fixes issue pandas-dev#25384 * Correct a typo of version number for interpolate() (pandas-dev#25418) * DEP: add pytest-mock to environment.yml (pandas-dev#25417) * BUG: Fix type coercion in read_json orient='table' (pandas-dev#21345) (pandas-dev#25219) * ERR: doc update for ParsingError (pandas-dev#25414) Closes pandas-devgh-22881 * ENH: Add in sort keyword to DatetimeIndex.union (pandas-dev#25110) * DOC: Rewriting of ParserError doc + minor spacing (pandas-dev#25421) Follow-up to pandas-devgh-25414. * API/ERR: allow iterators in df.set_index & improve errors (pandas-dev#24984) * BUG: Indexing with UTC offset string no longer ignored (pandas-dev#25263) * PERF/REF: improve performance of Series.searchsorted, PandasArray.searchsorted, collect functionality (pandas-dev#22034) * TST: remove never-used singleton fixtures (pandas-dev#24885) * BUG: fixed merging with empty frame containing an Int64 column (pandas-dev#25183) (pandas-dev#25289) * DOC: fixed geo accessor example in extending.rst (pandas-dev#25420) I realised "lon" and "lat" had just been switched with "longitude" and "latitude" in the following code block. So I used those names here as well. * TST: numpy RuntimeWarning with Series.round() (pandas-dev#25432) * CI: add __init__.py to isort skip list (pandas-dev#25455) * DOC: CategoricalIndex doc string (pandas-dev#24852) * DataFrame.drop Raises KeyError definition (pandas-dev#25474) * BUG: Keep column level name in resample nunique (pandas-dev#25469) Closes pandas-devgh-23222 xref pandas-devgh-23645 * ERR: Correct error message in to_datetime (pandas-dev#25467) * ERR: Correct error message in to_datetime Closes pandas-devgh-23830 xref pandas-devgh-23969 * Fix minor typo (pandas-dev#25458) Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> * CI: Set pytest minversion to 4.0.2 (pandas-dev#25402) * CI: Set pytest minversion to 4.0.2 * STY: use pytest.raises context manager (indexes) (pandas-dev#25447) * STY: use pytest.raises context manager (tests/test_*) (pandas-dev#25452) * STY: use pytest.raises context manager (tests/test_*) * fix ci failures * skip py2 ci failure * Fix minor error in dynamic load function (pandas-dev#25256) * Cythonized GroupBy Quantile (pandas-dev#20405) * BUG: Fix regression on DataFrame.replace for regex (pandas-dev#25266) * BUG: Fix regression on DataFrame.replace for regex The commit ensures that the replacement for regex is not confined to the beginning of the string but spans all the characters within. The behaviour is then consistent with versions prior to 0.24.0. One test has been added to account for character replacement when the character is not at the beginning of the string. * Correct contribution guide docbuild instruction (pandas-dev#25479) * TST/REF: Add pytest idiom to test_frequencies.py (pandas-dev#25430) * BUG: Fix index type casting in read_json with orient='table' and float index (pandas-dev#25433) (pandas-dev#25434) * BUG: Groupby.agg with reduction function with tz aware data (pandas-dev#25308) * BUG: Groupby.agg cannot reduce with tz aware data * Handle output always as UTC * Add whatsnew * isort and add another fixed groupby.first/last issue * bring condition at a higher level * Add try for _try_cast * Add comments * Don't pass the utc_dtype explicitly * Remove unused import * Use string dtype instead * DOC: Fix docstring for read_sql_table (pandas-dev#25465) * ENH: Add Series.str.casefold (pandas-dev#25419) * Fix PR10 error and Clean up docstrings from functions related to RT05 errors (pandas-dev#25132) * Fix unreliable test (pandas-dev#25496) * DOC: Clarifying doc/make.py --single parameter (pandas-dev#25482) * fix MacPython / pandas-wheels ci failures (pandas-dev#25505) * DOC: Reword Series.interpolate docstring for clarity (pandas-dev#25491) * Changed insertion order to sys.path (pandas-dev#25486) * TST: xfail non-writeable pytables tests with numpy 1.16x (pandas-dev#25517) * STY: use pytest.raises context manager (arithmetic, arrays, computati… (pandas-dev#25504) * BUG: Fix RecursionError during IntervalTree construction (pandas-dev#25498) * STY: use pytest.raises context manager (plotting, reductions, scalar...) (pandas-dev#25483) * STY: use pytest.raises context manager (plotting, reductions, scalar...) * revert removed testing in test_timedelta.py * remove TODO from test_frame.py * skip py2 ci failure * BUG: Fix potential segfault after pd.Categorical(pd.Series(...), categories=...) (pandas-dev#25368) * Make DataFrame.to_html output full content (pandas-dev#24841) * BUG-16807-1 SparseFrame fills with default_fill_value if data is None (pandas-dev#24842) Closes pandas-devgh-16807. * DOC: Add conda uninstall pandas to contributing guide (pandas-dev#25490) * fix pandas-dev#25487 add modify documentation * fix segfault when running with cython coverage enabled, xref cython#2879 (pandas-dev#25529) * TST: inline empty_frame = DataFrame({}) fixture (pandas-dev#24886) * DOC: Polishing typos out of doc/source/user_guide/indexing.rst (pandas-dev#25528) * STY: use pytest.raises context manager (frame) (pandas-dev#25516) * DOC: Fix pandas-dev#24268 by updating description for keep in Series.nlargest (pandas-dev#25358) * DOC: Fix pandas-dev#24268 by updating description for keep * fix MacPython / pandas-wheels ci failures (pandas-dev#25537) * TST/CLN: Remove more Panel tests (pandas-dev#25550) * BUG: caught typeError in series.at (pandas-dev#25506) (pandas-dev#25533) * ENH: Add errors parameter to DataFrame.rename (pandas-dev#25535) * ENH: GH13473 Add errors parameter to DataFrame.rename * TST: Skip IntervalTree construction overflow test on 32bit (pandas-dev#25558) * DOC: Small fixes to 0.24.2 whatsnew (pandas-dev#25559) * minor typo error (pandas-dev#25574) * BUG: in error message raised when invalid axis parameter (pandas-dev#25553) * BLD: Fixed pip install with no numpy (pandas-dev#25568) * Document the behavior of `axis=None` with `style.background_gradient` (pandas-dev#25551) * fix minor typos in dsintro.rst (pandas-dev#25579) * BUG: Handle readonly arrays in period_array (pandas-dev#25556) * BUG: Handle readonly arrays in period_array Closes pandas-dev#25403 * DOC: Fix typo in tz_localize (pandas-dev#25598) * BUG: secondary y axis could not be set to log scale (pandas-dev#25545) (pandas-dev#25586) * TST: add test for groupby on list of empty list (pandas-dev#25589) * TYPING: Small fixes to make stubgen happy (pandas-dev#25576) * CLN: Parmeterize test cases (pandas-dev#25355)

Fix validation error RT05

2c4455c

Fix pep8

c87102f

jreback added the Docs label Feb 4, 2019

thoo added 3 commits February 4, 2019 10:31

fix merge conflict

03aaa92

fix RT04

36a610a

jreback reviewed Feb 4, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

thoo added 3 commits February 4, 2019 19:44

fix as recommended

c2e24b3

Merge remote-tracking branch 'upstream/master' into Rt05

f5cfc8a

* upstream/master: Fix validation error type `SS05` and check in CI (pandas-dev#25133)

fix bullets

6e658f8

datapythonista requested changes Feb 5, 2019

View reviewed changes

thoo added 7 commits February 5, 2019 20:05

fix upon suggestions

5304b9c

fix upon suggestions

7601aed

fix failing tests

128dadb

replace with bullet

3d3e408

typo

522e76d

Retrigger :pandas-dev conda 27 failed

163e9e3

jreback added this to the 0.25.0 milestone Feb 8, 2019

thoo added 2 commits February 8, 2019 15:00

update code_checks.sh

25e7503

datapythonista reviewed Feb 13, 2019

View reviewed changes

Retrigger :pandas-devs failed second time

6ac909b

thoo added 2 commits February 17, 2019 13:00

Retrigger :pandas-devs failed second time

4e4f24a

Merge remote-tracking branch 'upstream/master' into Rt05

283861f

* upstream/master: TST: xfail excel styler tests, xref GH25351 (pandas-dev#25352)

datapythonista approved these changes Feb 20, 2019

View reviewed changes

WillAyd requested changes Feb 20, 2019

View reviewed changes

thoo added 3 commits February 20, 2019 14:21

fix at Series.unique

953159c

add PR10

94e5279

drop PR10

39ab010

thoo changed the title ~~Fix validation error type RT05 and check in CI~~ ~Fix validation error type RT05 and check in CI~ Clean up docstrings from functions related to RT05 errors Feb 21, 2019

thoo changed the title ~~~Fix validation error type RT05 and check in CI~ Clean up docstrings from functions related to RT05 errors~~ Clean up docstrings from functions related to RT05 errors Feb 21, 2019

fix PR10 error

64bd51b

thoo changed the title ~~Clean up docstrings from functions related to RT05 errors~~ Fix PR10 error and Clean up docstrings from functions related to RT05 errors Feb 21, 2019

WillAyd requested changes Feb 21, 2019

View reviewed changes

datapythonista reviewed Feb 21, 2019

View reviewed changes

thoo added 2 commits February 21, 2019 23:38

fix as recommended

7051e3c

Merge remote-tracking branch 'upstream/master' into Rt05

a35f869

* upstream/master: CLN: (re-)enable infer_dtype to catch complex (pandas-dev#25382)

datapythonista requested changes Feb 22, 2019

View reviewed changes

fix as recommended

b847e4e

WillAyd approved these changes Feb 27, 2019

View reviewed changes

WillAyd mentioned this pull request Feb 28, 2019

[DOC] Fix issues with DataFrame.aggregate page #24948

Closed

WillAyd merged commit 0a61ecd into pandas-dev:master Mar 1, 2019

		@@ -1292,7 +1292,7 @@ def __array__(self, dtype=None):
		values : numpy array

		@@ -1501,7 +1501,7 @@ def get_values(self):
		-------
		values : numpy array

Fix PR10 error and Clean up docstrings from functions related to RT05 errors #25132

Fix PR10 error and Clean up docstrings from functions related to RT05 errors #25132

Conversation

thoo commented Feb 4, 2019 • edited Loading

pep8speaks commented Feb 4, 2019 • edited Loading

Comment last updated on February 28, 2019 at 01:28 Hours UTC

codecov bot commented Feb 4, 2019

Codecov Report

codecov bot commented Feb 4, 2019 • edited Loading

Codecov Report

jreback commented Feb 4, 2019

datapythonista left a comment

Choose a reason for hiding this comment

jreback commented Feb 9, 2019

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thoo commented Feb 14, 2019

WillAyd commented Feb 14, 2019

jreback commented Feb 17, 2019

jreback commented Feb 19, 2019

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thoo Feb 20, 2019 • edited Loading

Choose a reason for hiding this comment

thoo Feb 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thoo Feb 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillAyd commented Feb 21, 2019

WillAyd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillAyd commented Feb 27, 2019

thoo commented Mar 1, 2019

WillAyd commented Mar 1, 2019

thoo commented Feb 4, 2019 •

edited

Loading

pep8speaks commented Feb 4, 2019 •

edited

Loading

codecov bot commented Feb 4, 2019 •

edited

Loading

thoo Feb 20, 2019 •

edited

Loading

thoo Feb 20, 2019 •

edited

Loading

thoo Feb 21, 2019 •

edited

Loading