CLN: Clean uses of super, part II #26230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-04-28 07:40:11 UTC |
topper-123
commented
Apr 28, 2019
|
|
||
| def isoformat(self, sep='T'): | ||
| base = super(_Timestamp, self).isoformat(sep=sep) | ||
| base = super().isoformat(sep=sep) |
There was a problem hiding this comment.
This changes the first parameter in super to implivitly be TimeStamp rather than _Timestamp, which is ok in this case.
topper-123
force-pushed
the
clean_super_II
branch
from
ecf5410 to
3ee7740
Compare
topper-123
commented
Apr 28, 2019
| # We want PandasObject.__repr__, which dispatches to __unicode__ | ||
| return super(ExtensionArray, self).__repr__() | ||
| # We want to bypass ExtensionArray.__repr__. | ||
| return str(self) |
There was a problem hiding this comment.
This ends up in both master and this PR to call self.__unicode__. __unicode__ isn't needed anymore so should be cleaned up in a future PR.
topper-123
commented
Apr 28, 2019
| # only result | ||
| result, how = (super(DataFrame, self.T) | ||
| ._aggregate(arg, *args, **kwargs)) | ||
| result, how = self.T._aggregate(arg, *args, axis=0, **kwargs) |
There was a problem hiding this comment.
I think this is clearer to read than the super version.
topper-123
force-pushed
the
clean_super_II
branch
from
3ee7740 to
ca14ff4
Compare
topper-123
force-pushed
the
clean_super_II
branch
from
ca14ff4 to
e1c0eb4
Compare
topper-123
commented
Apr 28, 2019
| if axis == 1: | ||
| return super(DataFrame, self.T).transform(func, *args, **kwargs).T | ||
| return self.T.transform(func, *args, axis=0, **kwargs).T | ||
| return super().transform(func, *args, **kwargs) |
There was a problem hiding this comment.
I think this is clearer to read than the super version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #26177. In addition to the uses of
superdealt with in #26177, there were some more advanced uses ofsuperin the code base, e.g. in classmethods and usingsuperto jump to a specific point in the MRO-chain.This PR specifically deals with:
super(..., self)in pyx-filessuper(..., cls)in the whole code basesuper, se comments .