TST: Add tests for groupby categorical values with axis=1 #27788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
changed the title
gfyoung
added
Testing
WillAyd
requested changes
Aug 7, 2019
| def test_groupby_categorical_axis_1(code): | ||
| # GH 13420 | ||
| df = DataFrame({"a": [1, 2, 3, 4], "b": [-1, -2, -3, -4], "c": [5, 6, 7, 8]}) | ||
| grp = pd.Categorical.from_codes(code, categories=list("abc")) |
There was a problem hiding this comment.
Can you call this cat instead of grp? The latter is typically the result of an actual groupby
There was a problem hiding this comment.
ok, changed! @WillAyd and thanks for taking a look!
|
lgtm. @WillAyd |
WillAyd
approved these changes
Aug 7, 2019
|
Thanks @charlesdong1991 ! |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is xref #27700 (comment)
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff