CLN: 29547 replace .format() with f-strings #32044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
smartvinnetou
changed the title
datapythonista
requested changes
Feb 17, 2020
| f"{h[:HASH_LEN]:{HASH_LEN}} " | ||
| f"{d.isoformat()[:10]:10} " | ||
| f"{s:<{SUBJ_LEN}} " | ||
| f"{p[-20:]:<{PATH_LEN}}" |
There was a problem hiding this comment.
This is changing the behavior, can you test this and make sure it works as the original.
There was a problem hiding this comment.
In what way do you see the behaviour changed?
1 task
|
I was checking, and seems like this script is not working, and I don't think anyone is using it. I'm removing it in #32071, so better to close this PR. Thanks for the work anyway, and sorry for not detecting that earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces .format() with f-strings as requested in #29547.
It did this replacement in scripts/find_commits_touching_func.py
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff