CLN: Remove unused script find_commits_touching_func.py #32071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
simonjayhawkins
approved these changes
Feb 18, 2020
|
LGTM |
|
I vaguely recall some contributor using this recently (@3vts or @MomIsBestFriend - either of you?) No objections to getting rid of it, though cc'ing them in case they have a counter point |
|
I did not work on this file. Just tested and seems it does not work as stated earlier |
|
@WillAyd I cannot recall when I used this script. I think I was the one who were one on this as part of the I have no objections in removing this script as I never used it, and for the fact that I haven't seen anyone else use it. |
|
OK thanks all for comments and @datapythonista for PR |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying the script
find_commits_touching_func.pyand doesn't seem to be working. Tried for many existing functions, and never get any result. I guess it doesn't work with newer git versions, or with the latest dependencies. And if nobody realized of this before, I assume nobody is using this script (and in any case, a separate project would be more appropriate for it, since I don't think it's pandas specific).The script was being refactored in #32044, that's why I was having a look.