Skip to content

CLN remove unnecessary trailing commas to get ready for new version of black: generic -> blocks #35950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 28, 2020
Merged

CLN remove unnecessary trailing commas to get ready for new version of black: generic -> blocks #35950

merged 8 commits into from
Aug 28, 2020

Conversation

MarcoGorelli
Copy link
Member

xref #35925

@MarcoGorelli MarcoGorelli mentioned this pull request Aug 28, 2020
Closed
23 tasks
@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks labels Aug 28, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 28, 2020
simonjayhawkins
simonjayhawkins approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcoGorelli lgtm

charlesdong1991
charlesdong1991 approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@charlesdong1991 charlesdong1991 merged commit 00cb992 into pandas-dev:master Aug 28, 2020
@MarcoGorelli MarcoGorelli deleted the even-more-trailing-commas branch August 28, 2020 16:50
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Aug 31, 2020
@MarcoGorelli @AlexKirko
CLN remove unnecessary trailing commas to get ready for new version o…
a97623a 
…f black: generic -> blocks (pandas-dev#35950)

* pandas/core/groupby/generic.py

* pandas/core/groupby/groupby.py

* pandas/core/groupby/ops.py

* pandas/core/indexes/datetimelike.py

* pandas/core/indexes/interval.py

* pandas/core/indexes/numeric.py

* pandas/core/indexes/range.py

* pandas/core/internals/blocks.py
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@MarcoGorelli
CLN remove unnecessary trailing commas to get ready for new version o…
fe98274 
…f black: generic -> blocks (pandas-dev#35950)

* pandas/core/groupby/generic.py

* pandas/core/groupby/groupby.py

* pandas/core/groupby/ops.py

* pandas/core/indexes/datetimelike.py

* pandas/core/indexes/interval.py

* pandas/core/indexes/numeric.py

* pandas/core/indexes/range.py

* pandas/core/internals/blocks.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

+1 more reviewer

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clean Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoGorelli @charlesdong1991 @simonjayhawkins