Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate Index.is_boolean #50176

Merged
merged 2 commits into from
Jan 14, 2023
Merged

DEPR: deprecate Index.is_boolean #50176

merged 2 commits into from
Jan 14, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 mentioned this pull request Dec 10, 2022
Closed
10 tasks
phofl
phofl reviewed Dec 11, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests as well? Same as the other, have to hold off a bit

@topper-123
Copy link
Contributor Author

Can you add tests as well?

I added a test in pandas/tests/indexes/common.py. Do you mean something additional?

@phofl
Copy link
Member

phofl commented Dec 11, 2022

Missed this, sorry

@topper-123 topper-123 added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Dec 13, 2022
@topper-123 topper-123 added this to the 2.0 milestone Dec 13, 2022
@datapythonista datapythonista mentioned this pull request Jan 5, 2023
Open
@phofl
Copy link
Member

phofl commented Jan 12, 2023

needs a rebase, can merge afterwards

phofl
phofl reviewed Jan 13, 2023
View reviewed changes
pandas/core/indexes/base.py Outdated
@@ -2210,6 +2213,12 @@ def is_boolean(self) -> bool:
>>> idx.is_boolean()
False
"""
warnings.warn(
f"{type(self).__name__}.is_boolean is deprecated."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other pr, needs a whitespace here

@topper-123
Copy link
Contributor Author

Updated.

@phofl phofl merged commit 9116f32 into pandas-dev:main Jan 14, 2023
@phofl
Copy link
Member

phofl commented Jan 14, 2023

Thx @topper-123

@topper-123 topper-123 deleted the deprecate_Index.is_boolean branch January 14, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@topper-123 @phofl