DEPR: deprecate Index.is_floating #50235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuuun
changed the title
|
@topper-123 Hi, Can you check if I have done right? |
topper-123
added
Deprecate
topper-123
approved these changes
Dec 14, 2022
Closed
10 tasks
phofl
approved these changes
Jan 12, 2023
|
thx @yuuun |
Comment on lines
+2304
to
+2305
| f"{type(self).__name__}.is_floating is deprecated." | ||
| "Use pandas.api.types.is_float_dtype instead", |
There was a problem hiding this comment.
probably could do with a space here.
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Jan 12, 2023
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Jan 13, 2023
topper-123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.0.0.rstfile if fixing a bug or adding a new feature.