DEPR: Properly enforce group_keys defaulting to False in resample

[rhshadrach]

• closes #xxxx (Replace xxxx with the GitHub issue number)
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Some things that were missed in enforcing the deprecation of #34998. Since lib.no_default is truthy, we were treating the default in resample as True rather than False.

[phofl]

thx @rhshadrach

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 2.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 c2ef58e55936668c81b2cc795d1812924236e1a6

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #52071: DEPR: Properly enforce group_keys defaulting to False in resample'

4. Push to a named branch:

git push YOURFORK 2.0.x:auto-backport-of-pr-52071-on-2.0.x

5. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52071 on branch 2.0.x (DEPR: Properly enforce group_keys defaulting to False in resample)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[phofl]

@rhshadrach can you backport?