Skip to content

(botched; see #660) Fix JSDoc highlighting for optional parameters #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

(botched; see #660) Fix JSDoc highlighting for optional parameters #659

wants to merge 35 commits into from

Conversation

TamsynUlthara
Copy link
Contributor

Fixes #574.

bounceme and others added 30 commits September 18, 2016 01:41
@bounceme
multi-braceless statements (#636)
d3e952c 
* multi-braceless statements

This changes:
```
if (1)
  for (;;)
  i +=
  l
```
to:
```
if (1)
  for (;;)
    i +=
      l
```
@bounceme
date,format
ebd222b
@bounceme
Update javascript.vim
48567e0
@bounceme
Update javascript.vim
6426110
@bounceme
change to searchpair helper
aa37199
@bounceme
change num <= 0 to 0
b2ded12
@bounceme
more number conversion
5df8b34
@bounceme
prev
3b38947
@bounceme
fix concat bug
ff5f3f1
@bounceme
small skip_func improvements (#637)
1219b15 
this will improve performance depending on the file. I will try and clean it a little
@bounceme
more minor optimizations (#638)
afbe284
@amadeus
Fix jsGlobalNodeObjects and jsFuncCall priority
a7225e4 
Give jsGlobalNodeObjects a higher priority that can therefore be
targeted if desired.
@bounceme
optimize top scope indentation speed (#640)
d94ab71 
makes a huge difference when not in a 'scope'. avoids checking the whole file
* improve helper
@bounceme
normalize header in vim and current, date (#642)
3bb395c 
Any issues with this? It doesn't rlly mean anything, just something to satisfy vim/dev
@remi
Fix jsFlowTypeCustom regex to allow dots
fcdc1dc
@amadeus
Merge pull request #645 from remiprev/fix/js-flow-type-custom-regex
2202e58 
Fix jsFlowTypeCustom regex to allow dots
@bounceme
simplify comments
ce7c06c
@bounceme
more string/comment cleaning
5453eb0
@bounceme
remove rar
02c8c64
@bounceme
more optimization (#646)
dc67840
@bounceme
switch accuracy and performance (#647)
92f1d98
@bounceme
clean isBlock (#648)
6ecbda3
@bounceme
change regex case
d6b2fd5
@bounceme
better line cleaning (#649)
77c4ae6
@bounceme
more regex line endings
840f129
@bounceme
factor out
88111be
@bounceme
small regex changes
6656f37
@bounceme
short circuit cache check
833d6ec
@bounceme
fail earlier
c76d65b
@bounceme
wrap for magic (#651)
cd4ace4
@TamsynUlthara
Copy link
Contributor Author

Aw, crap. Botched that.

@TamsynUlthara TamsynUlthara changed the base branch from master to develop October 5, 2016 20:48
@TamsynUlthara TamsynUlthara changed the base branch from develop to master October 5, 2016 20:52
@TamsynUlthara
Copy link
Contributor Author

Post-mortem: the hub CLI tool automatically made the PR against master while I wrote it against develop, and I couldn't figure out how to get that unstuck after I force-updated the branch to resubmit it against master. Resubmitted it as #660.

@TamsynUlthara TamsynUlthara changed the title Fix JSDoc highlighting for optional parameters (botched; see #660) Fix JSDoc highlighting for optional parameters Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TamsynUlthara @bounceme @amadeus @remi