Repository navigation
is https://github.com/hl-archive-node/nanoreth affected by the issue fixed by https://github.com/paradigmxyz/reth/pull/28264 ? #28304
|
hi team, is https://github.com/hl-archive-node/nanoreth affected by the issue fixed by #28264 ? |
Replies: 1 comment 1 reply
|
Yes. nanoreth's current code includes the bug that #28264 fixes. What nanoreth builds against: on its default branch ( The code: at that revision, self.walker.key().is_some_and(|key| key.starts_with(&seek_prefix)) &&Tested: I added the PR's regression test, With the one-line change from #28264 ( Does it run in practice? nanoreth imports blocks through the engine API ( Fix: the change is a single line. Cherry-picking #28264 onto |
Yes. nanoreth's current code includes the bug that #28264 fixes.
What nanoreth builds against: on its default branch (
node-builder, last commit 2c6525d), every reth crate,reth-trie-dbandreth-trie-commonincluded, comes fromhl-archive-node/rethat14509628ed37e9a9b7110ea855a67f427c4d61fc(2026-09-18).[patch.crates-io]doesn't override the trie crates. #28264 was merged on 2026-11-03, so that revision predates it.The code: at that revision,
crates/trie/trie/src/node_iter.rsstill has the condition the PR replaces:Tested: I added the PR's regression test,
inserted_leaf_before_deeper_stored_branch_is_included, tohl-…