Skip to content
Discussion options

You must be logged in to vote

Yes. nanoreth's current code includes the bug that #28264 fixes.

What nanoreth builds against: on its default branch (node-builder, last commit 2c6525d), every reth crate, reth-trie-db and reth-trie-common included, comes from hl-archive-node/reth at 14509628ed37e9a9b7110ea855a67f427c4d61fc (2026-09-18). [patch.crates-io] doesn't override the trie crates. #28264 was merged on 2026-11-03, so that revision predates it.

The code: at that revision, crates/trie/trie/src/node_iter.rs still has the condition the PR replaces:

self.walker.key().is_some_and(|key| key.starts_with(&seek_prefix)) &&

Tested: I added the PR's regression test, inserted_leaf_before_deeper_stored_branch_is_included, to hl-…

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@aliForward
Comment options

Answer selected by aliForward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Help
Labels
None yet
2 participants