use npm packages instead of github for file-saver and adler32cs #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great -- thanks for this! jsPDF pre-dates node and npm, if you can imagine such a thing. |
This was referenced Sep 11, 2017
|
No prob! |
|
Is this issue being brought back in latest version 1.4.1 & 1.5.3 as well? I'm not able to install it checks for git reference for file-saver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces github dependencies with their respective npm modules. Addresses following related issues:
#1389
#1363
#1065
#853
Now uses latest Filesaver.js version
1.3.3instead of version1.1.20151003