Update to PostCSS 8 #5166
Merged
Update to PostCSS 8 #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
aminya
approved these changes
Sep 28, 2020
|
@mischnic New PostCSS recommends moving
Will this recommendation work for Parcel 2? |
|
We require plugins from the users project, so that should work. Or do you mean the Parcel itself should have postcss as a peerdependency? E.g. so that this call uses the user's postcss version? That would be rather difficult... |
|
@mischnic Parcel should use I think optional peer dependency in Parcel will solve this problem. |
|
Parcel auto-install feature is awesome 😍 I use Parcel for all my projects (including PostCSS website). |
|
🎉 😄 |
|
What is the current blocker? I want to use PostCSS 8 on the PostCSS website. |
DeMoorJasper
approved these changes
Oct 6, 2020
|
@DeMoorJasper Should we add postcss@8 as a dependency to the integration test monorepo package? |
|
@mischnic I don't think it's necessary as it's already gonna get installed anyway by all the references it already has in various package.json's in the monorepo. Feel free to add it though |
|
Any way to use this fix before next Parcel 2 beta release? I want to update postcss.org and add a guide to PostCSS 8 Migration guide. |
|
|
|
This makes Parcel 2 completely unusable if the PostCSS plugins your codebase relies on doesn't support PostCSS 8 yet. I think adding PostCSS 8 support is great, but on the user-end it's a pretty minor improvement that blocks Parcel users from upgrading to v2. In my case, it's preset-env which requires many plugin dependencies to be upgraded before it can do a PostCSS 8 release. IMO this is a pretty common PostCSS plugin to use with PostCSS so I imagine many users may encounter this blocker. Is it possible to support both PostCSS 7 and 8 somehow? |
|
See #5152 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #5152