Repository navigation
v0.19.0
What's Changed
Fixed
- Pinned
parisek/styleguideto>=1.11,<1.18(#89).parisek/styleguide
1.18.0 (PR parisek/styleguide#144) changedRenderer::render()from
returning an HTML string plus anhttp_response_code()side effect to
returning aResultobject carrying the status, but
Styleguide::renderObserved()— the methodFixtureAudit\Auditoruses —
was not updated to forward that status: it takes only->bodyfrom the
Resultand its own return array has no status key at all.
Auditor::renderFixture()detects a fixture render failure by resetting
http_response_code(200)and reading it back after the render (documented
byRenderer::render()itself as the stable signal); with nothing calling
http_response_code()any more,Auditorcan no longer tell a failed
render (component/broken's{{ 1 / 0 }}) from a successful one — every
fixture reads backOKregardless of whether it actually rendered.
fields-contract's render-failure detection has no other signal to fall
back on without an upstream change torenderObserved()'s return shape, so
the constraint is capped below1.18.0(last known-good:1.17.0) until
parisek/styleguiderestores an observable status. Confirmed
parisek/styleguide1.17.0 through 1.19.0-adjacent CI drift was the sole
cause:composer installfrom a clean checkout ofmainreproduced the
same 5AuditorTestfailures purely from the unpinned constraint floating
onto 1.19.0, with no other change involved. fields-migrateon a component now strips the twig front-comment once
<name>.yamlis written, the same way page/doc migration always has
(#84). Component migration used to leave the comment on the twig, so every
migrated component carried its metadata twice — proven downstream on a
49-component Drupal project where every already-migrated component still
opened with the samename:/usage:/category:block its<name>.yaml
already recorded. The strip happens only after the yaml write completes,
mirroring the existing page/doc write-then-strip order.
Added
fields-migrate --strip-comment [--write] <component-dir>|--root=<root>
retires the front-comment on a component that was already migrated before
the fix above, without re-deriving anything. It removes the comment only
when every key it carries matches<name>.yaml— normalising a
comma-separatedusage:against a yaml list — and refuses the component,
per key, when the yaml disagrees or is missing a key, printing what
differs. Dry run by default, like--rename-structural-types.
Pull Requests
- #88 — fix(migrate): strip a component's twig front-comment after migration
- #90 — fix(deps): cap parisek/styleguide below the render-status regression
Full Changelog: v0.18.1...v0.19.0