Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Conversation

@amaury1093
Copy link
Collaborator

@amaury1093 amaury1093 commented Oct 25, 2018

On parity-ethereum, api.pollMethod('eth_getTransactionReceipt') didn't throw if there was no receipt yet. Now it throws.

So we manually poll/catch for 20s.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 172

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 46.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/light.js/src/rpc/other/post.ts 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
packages/light.js/src/rpc/other/post.ts 2 55.0%
Totals Coverage Status
Change from base Build 169: -0.07%
Covered Lines: 840
Relevant Lines: 1805

💛 - Coveralls

@amaury1093 amaury1093 requested a review from axelchalon October 25, 2018 14:12
@amaury1093 amaury1093 merged commit 4e126be into master Oct 25, 2018
@amaury1093 amaury1093 deleted the am-receipt branch October 25, 2018 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants