This repository was archived by the owner on May 24, 2022. It is now read-only.
runParity: resolve once Parity's dirs have been created ; isParityRunning: speed up #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 184
💛 - Coveralls |
axelchalon
changed the title
|
Can you fix the lint issue? |
|
Once this is merged, I'll update the bump the version on npm, and we can update Fether right after. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(should I bump the version of @parity/electron to reference the new version in Fether? or I guess we can just update the yarn.lock)
runParity
Fixes Fether not being able to extract the token from Parity on the first run of Fether with no prior install of Parity
isParityRunning
fix #27