Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Conversation

@amaury1093
Copy link
Collaborator

Use strict mode in tsconfig.

This PR is easier read commit by commit.

@coveralls
Copy link

coveralls commented Nov 22, 2018

Pull Request Test Coverage Report for Build 246

  • 60 of 113 (53.1%) changed or added relevant lines in 34 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+5.5%) to 52.452%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/abi/src/spec/event/event.ts 2 3 66.67%
packages/abi/src/spec/function.ts 2 3 66.67%
packages/electron/src/signerNewToken.ts 0 1 0.0%
packages/light.js/src/rpc/utils/createRpc.ts 2 3 66.67%
packages/abi/src/decoder/decoder.ts 6 8 75.0%
packages/abi/src/spec/paramType/format.ts 4 6 66.67%
packages/api/src/transport/TransportError.ts 0 2 0.0%
packages/contracts/src/signaturereg.ts 0 2 0.0%
packages/electron/src/fetchParity.ts 0 2 0.0%
packages/electron/src/getParityPath.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/contracts/src/badgereg.ts 1 0.0%
packages/electron/src/runParity.ts 1 0.0%
Totals Coverage Status
Change from base Build 237: 5.5%
Covered Lines: 942
Relevant Lines: 1792

💛 - Coveralls


static encodeToken (token: Token, index = 0): Mediate {
if (!isInstanceOf(token, Token)) {
static encodeToken (token?: Token, index = 0): Mediate {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we're using the token?: Token syntax to define an optional parameter here, and we're using the ParamType[] | undefined syntax in the other file?

also out of curiosity, why are we setting the first parameter of encode and encodeToken as optional if they really are required?

resultIcon = null;
}

return { title, icon };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to return { title, icon: resultIcon } here?


class Encoder {
static encode (tokens: Token[]) {
static encode (tokens?: Token[]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@axelchalon
Copy link
Contributor

👍

@amaury1093 amaury1093 merged commit 930f2da into master Nov 23, 2018
@amaury1093 amaury1093 deleted the am-strict branch November 23, 2018 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants