Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix WASM block producer panic #11206

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Fix WASM block producer panic #11206

merged 7 commits into from
Apr 13, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Apr 12, 2022 •
edited
Loading

Wrap the events in the event storage into a Box to reduce memory usage on loading.
Closes #11132

@ggwpez
Box events
9fb1887 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 12, 2022
@ggwpez ggwpez self-assigned this Apr 12, 2022
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 12, 2022
@ggwpez ggwpez mentioned this pull request Apr 12, 2022
Closed
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Apr 12, 2022
@ggwpez
Fix tests
981c50f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Revert "Box events"
115337c 
This reverts commit 9fb1887.
@ggwpez
Revert "Fix tests"
3df82e2 
This reverts commit 981c50f.
@ggwpez
Use simpler approach
5cf70c4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
kianenigma
kianenigma approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While less necessary than boxing Call, seems reasonable to me.

@ggwpez ggwpez added A0-please_review Pull request needs code review. C7-high ❗️ and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 13, 2022
@ggwpez ggwpez changed the title Boxed events Fix WASM block producer panic Apr 13, 2022
@ggwpez
Update doc
3f5ad28 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr bkchr added C1-low PR touches the given topic and has a low impact on builders. and removed C7-high ❗️ labels Apr 13, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Apr 13, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 32510e1 into master Apr 13, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-boxed-events branch April 13, 2022 11:55
@Dengjianping Dengjianping mentioned this pull request Jul 7, 2022
Merged
10 tasks
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@ggwpez @DaviRain-Su
Fix WASM block producer panic (paritytech#11206)
e3d7aa9 
* Box events

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Box events"

This reverts commit 9fb1887.

* Revert "Fix tests"

This reverts commit 981c50f.

* Use simpler approach

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Sep 28, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ggwpez @ark0f
Fix WASM block producer panic (paritytech#11206)
5e53d49 
* Box events

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Box events"

This reverts commit 9fb1887.

* Revert "Fix tests"

This reverts commit 981c50f.

* Use simpler approach

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

@athei athei Awaiting requested review from athei

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev wasm executor panics on block production
3 participants
@ggwpez @kianenigma @bkchr