New extrinsic dispatch model #678

gavofyork · 2018-09-06T15:51:00Z

Closes #651
Closes #184

This refactors pretty much the extrinsic dispatch system from signing to execute. Also repots the primitives/generic module.

TODO:

bkchr · 2018-09-07T11:28:15Z

substrate/runtime-support/src/dispatch.rs

 		$($rest:tt)*
 	) => {
 		impl<$trait_instance: $trait_name> $mod_type<$trait_instance> {
 			pub fn json_metadata() -> &'static str {
-				concat!(r#"{ "name": ""#, stringify!($mod_type), r#"", "calls": ["#,
-					__calls_to_json!(""; $($rest)*), " ] }")
+				concat!(r#"{ "name": ""#, stringify!($mod_type), r#"", "calls": [ "#,


If we do not have multiple call I would change the json from "calls": [ { .. }] to "call": { .. }.

bkchr · 2018-09-07T11:28:42Z

substrate/runtime-support/src/dispatch.rs

@@ -627,65 +386,30 @@ macro_rules! __impl_json_metadata {
 #[macro_export]
 #[doc(hidden)]
 macro_rules! __calls_to_json {


Nitpick: rename to __call_to_json

pepyakin · 2018-09-07T10:28:05Z

substrate/runtime/example/src/lib.rs

+//
+// The `Result` is required as part of the syntax (and expands to the conventional dispatch
+// result of `Result<(), &'static str>`). The index after `=` must be unique within this
+// enum (the `PrivCall` enum is allowed to reuse indexes).


There is no PrivCall anymore, right?

pepyakin · 2018-09-07T10:29:34Z

substrate/runtime/system/src/lib.rs

+		Some(RawOrigin::Inherent) => Ok(()),
+		_ => Err("bad origin"),
+	}
+}


Can we leave a comment to each of this ensure_ functions?

pepyakin · 2018-09-07T11:42:49Z

substrate/runtime/primitives/src/generic/checked_extrinsic.rs

+	}
+
+	fn apply(self) -> Result<(), &'static str> {
+		self.function.dispatch(self.signed.into())	// TODO gav: remove '&'.


Which &? : )

pepyakin · 2018-09-07T11:43:34Z

substrate/runtime/primitives/src/generic/checked_extrinsic.rs

+// You should have received a copy of the GNU General Public License
+// along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Generic implementations of Extrinsic/Header/Block.


Can we update this doc?

pepyakin · 2018-09-07T11:43:43Z

substrate/runtime/primitives/src/generic/block.rs

+// You should have received a copy of the GNU General Public License
+// along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Generic implementations of Extrinsic/Header/Block.


Can we update this doc?

pepyakin · 2018-09-07T11:44:03Z

substrate/runtime/primitives/src/generic/header.rs

+// You should have received a copy of the GNU General Public License
+// along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Generic implementations of Extrinsic/Header/Block.


Can we update this doc?

pepyakin · 2018-09-07T11:44:48Z

substrate/runtime/primitives/src/generic/tests.rs

+// You should have received a copy of the GNU General Public License
+// along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Generic implementations of Extrinsic/Header/Block.


Can we update this comment?

pepyakin · 2018-09-07T12:17:18Z

substrate/runtime/contract/src/tests.rs

@@ -439,7 +443,7 @@ fn refunds_unused_gas() {
 		Balances::set_free_balance(&0, 100_000_000);
 		Balances::increase_total_stake_by(100_000_000);

-		assert_ok!(Contract::call(&0, 1, 0, 100_000, Vec::new()));
+		assert_ok!(Contract::call(Origin::signed(0), 1, 0, 100_000, Vec::new()));


👍 much readable now!

gavofyork · 2018-09-07T17:16:08Z

@pepyakin grumbles addressed.

…-origin

…rs-generic-over-hasher-and-rlpcodec * origin/master: Fixed sync stalling when import queue is full (#691) New extrinsic dispatch model (#678) remove parachain's Cargo.lock (#682) Implement json metadata for outer events (#672) Improvements to the Kademlia system (#688) Use BufReader and BufWriter (#684) Switch to using parity/rust:substrate which has rust nightly-2018-08-31 (#686) Update to latest libp2p (#673) Implement storage json metadata (#670) impl MaybeEmpty for H256 and u64 (aka AccountId in prod/tests) (#665) Speedup compilation (#671) Remove requirement of function indices for decl_module! (#666) DigestItem trait (v2) (#650)

…aritytech#678) * service/src/lib.rs: Register network event stream for authority disc Previously one would create a sender and receiver channel pair, pass the sender to the build_network_future through the service builder and funnel network events returned from polling the network service into the sender to be consumed by the authority discovery module owning the receiver. With recent changes it is now possible to register an event_stream with the network service directly, thus one does not need to make the detour through the build_network_future. This commit is an adjusted clone of one targeting the Substrate repository. * service/src/lib.rs: Fix futures::stream imports * [TMP] *: Replace polkadot-upstream with feature branch * Revert "[TMP] *: Replace polkadot-upstream with feature branch" This reverts commit 0c947b04ab80488bfca16c5aeac9657b77a93a44.

* Make use of `runtime_interface` for parachain externalities This also changes the encoding of the `ValidationResult` return value to match the default encoding used in Substrate. * Bump versions (paritytech#655) * Bump version * Update Cargo lock and bump runtime version * Remove balance transfer disabler. * Fix checking that `get_heads` exists (paritytech#657) * Tweak some Kusama params (paritytech#659) * Tweak some Kusama params - Council elections daily - No treasury burn - Bonding/slash defer periods of 7 days * Bump runtime * Bump version * Update Substrate (paritytech#661) * Make compat with exit-future updates * Update exit-future entirely * Tidy * Bump Substrate * Update branch * Add back sudo and fixing compilation * Increase nick deposit (10 KSM) and require 2 councillors to slash (paritytech#663) * Bump Substrate (paritytech#664) * Replace Substrate mentions in license headers with Polkadot (paritytech#674) * Fix typo in comment (paritytech#671) * Bump Substrate, add Identity module (paritytech#676) * Bump Substrate, add Identity module * Bump Substrate again * Update futures and tokio for browser light client (paritytech#673) * Make availability-store compile for WASM * Use --manifest-path instead * Make validation work on wasm! * Switch to Spawn trait * Migrate validation to std futures * Migrate network to std futures * Final changes to validation * Tidy up network * Tidy up validation * Switch branch * Migrate service * Get polkadot to compile via wasm! * Add browser-demo * Add initial browser file * Add browser-demo * Tidy * Temp switch back to substrate/master * tidy * Fix wasm build * Re-add release flag * Switch to polkadot-master * Revert cli tokio version to avoid libp2p panic * Update tokio version * Fix availability store tests * Fix validation tests * Remove futures01 from availability-store * Fix network tests * Small changes * Fix collator * Fix typo * Revert removal of tokio_executor that causes tokio version mismatch panic * Fix adder test parachain * Revert "Revert removal of tokio_executor that causes tokio version mismatch panic" This reverts commit cfeb50c01d8df5e209483406a711e64761b44ae9. * Update availability-store/src/worker.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> * Update network/src/lib.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> * Update network/src/lib.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> * Box pin changes * Asyncify network functions * Clean up browser validation worker error * Fix av store test * Nits * Fix validation test * Switch favicon * Fix validation test again * Revert "Asyncify network functions" This reverts commit f20ae6548dc482cb1e75bc80641cfe55c6131a53. * Add async blocks back in * Fix typo in comment (paritytech#672) * Add the /ws bootnode to the chain specs (paritytech#681) * Revert "Revert "Revert removal of tokio_executor that causes tokio version mismatch panic"" (paritytech#685) This reverts commit 938f411a9365e9c5fb16bfedb62aacac4403d063. * Fix bootnodes PeerIds (paritytech#683) * Fixes a flaky test (paritytech#675) * Fixes a flaky test * Renames a var * Do not unit the errors in tests * Bump Substrate (paritytech#686) * update to latest renames * Bump Substrate * Bump substrate * Merge some things from `ashley-compile-to-wasm` (paritytech#687) * Make availability-store compile for WASM * Use --manifest-path instead * Make validation work on wasm! * Switch to Spawn trait * Migrate validation to std futures * Migrate network to std futures * Final changes to validation * Tidy up network * Tidy up validation * Switch branch * Migrate service * Get polkadot to compile via wasm! * Add browser-demo * Add initial browser file * Add browser-demo * Tidy * Temp switch back to substrate/master * tidy * Fix wasm build * Re-add release flag * Add the /ws bootnode to the chain specs * Copy changes from master * Switch branch * Switch libp2p and add wasm-timer * Switch back libp2p and add rand * Fix bootnodes PeerIds * use browser indexdb * Reduce changeset * Add matrix release alert script and gitlab job (paritytech#688) * Add matrix release alert script and gitlab job * Update .gitlab-ci.yml Co-Authored-By: Kirill Pimenov <kirill@parity.io> * Rewrite some Future structs as async functions (paritytech#679) * Squashed commit of the following: commit e97a17157ae0887320994661e2f816275fc75b76 Author: Ashley <ashley.ruglys@gmail.com> Date: Tue Dec 10 15:06:28 2019 +0100 Rewrite some functions as async commit 970e485179f1e087cf0a51c6a4e71f923e87df45 Merge: f98966ac 4782840 Author: Ashley <ashley.ruglys@gmail.com> Date: Tue Dec 10 11:19:37 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-futures-update commit f98966ac188067158071d1e3e243c34ea5738f56 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 23:40:20 2019 +0100 Add async blocks back in commit 7fa88af0271db659de9274c94cb8e7eead0e4289 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 23:17:02 2019 +0100 Revert "Asyncify network functions" This reverts commit f20ae6548dc482cb1e75bc80641cfe55c6131a53. commit 82413550cdac40bd14a09f62df12de49dd7e55af Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 19:09:55 2019 +0100 Fix validation test again commit 47e002b08369c9c775b92aea9b6f6ed81b30241b Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 19:07:43 2019 +0100 Switch favicon commit 0c5c1409078fc57120a39e40ec5cb1763d67d593 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:54:10 2019 +0100 Fix validation test commit 8bb6a0189fe824da09054cbf5b06f11a0f87072d Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:53:54 2019 +0100 Nits commit 33410f3a4910d3e688956cecfcca02cc2dfa6a7a Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:43:09 2019 +0100 Fix av store test commit f0c517eb240c42848cdb3305e0b554ef407bdfaa Merge: 938f411a 60e72111 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:21:39 2019 +0100 Merge branch 'ashley-futures-updates' into ashley-futures-update commit 60e72111651f2b366592c1e56756c6bf5d8ce2f1 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:19:40 2019 +0100 Clean up browser validation worker error commit f20ae6548dc482cb1e75bc80641cfe55c6131a53 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 18:16:40 2019 +0100 Asyncify network functions commit b22758d0a3852d701923bd238484e1c9eabec5e2 Merge: 2e8b05ed ca8d5c5 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:47:26 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-futures-updates commit 2e8b05edf1a1fadd6943f967c27b6d34675ba06a Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:45:52 2019 +0100 Box pin changes commit 08bfdf7f2d27721abffee49221213304ebc4fd47 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:15:38 2019 +0100 Update network/src/lib.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> commit d8be456c508d5e5a03178db45d9f272b302a8a65 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:15:32 2019 +0100 Update network/src/lib.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> commit ec7367276fdd374b19f41555fd5985454c559600 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:14:36 2019 +0100 Update availability-store/src/worker.rs Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com> commit 938f411a9365e9c5fb16bfedb62aacac4403d063 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 17:05:05 2019 +0100 Revert "Revert removal of tokio_executor that causes tokio version mismatch panic" This reverts commit cfeb50c01d8df5e209483406a711e64761b44ae9. commit f92f58044b4fe04bde73a60820d154080dd64b16 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 15:47:35 2019 +0100 Fix adder test parachain commit cfeb50c01d8df5e209483406a711e64761b44ae9 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 15:31:36 2019 +0100 Revert removal of tokio_executor that causes tokio version mismatch panic commit 5bcb83a122b9a30f240a238ca670c6b658f4ddf1 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 15:17:55 2019 +0100 Fix typo commit fc02b1dc16e277649677396833a8d70e8588a56c Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 15:02:50 2019 +0100 Fix collator commit 6c4ff5b3bf1084a618ffec2d864090c9c8077f0f Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 14:35:37 2019 +0100 Small changes commit e1338cb4450df5377d8c911da56445914d667472 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 14:24:42 2019 +0100 Fix network tests commit 4e458f7a91c1ed5c986795f40ed55e596d176c4b Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 12:25:26 2019 +0100 Remove futures01 from availability-store commit 5729f6cd6b53f061ff155320c815509feb02309e Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 12:22:33 2019 +0100 Fix validation tests commit a820612565b42780f8b6c09c9c1c30f06a9985ba Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 12:01:48 2019 +0100 Fix availability store tests commit 112344faeee5f8f03b3b87c6baf7036a7fcbe415 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 11:36:03 2019 +0100 Update tokio version commit d2de6d8b3f0c3682679fe437d5459ac50a3c3895 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 11:33:25 2019 +0100 Revert cli tokio version to avoid libp2p panic commit 0c5f24e0c1131ac58a947448456e7fb62c869702 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 9 11:27:13 2019 +0100 Switch to polkadot-master commit 2e2311e33a4af87c2c545094ea8cb595cd6cfe2d Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Dec 6 15:07:21 2019 +0100 Re-add release flag commit 6adc1b6114e154a590acf82acfaf0c1265409518 Merge: 9767f832 5e9542c Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Dec 6 13:36:35 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit 9767f8325c33211065ef6830becdac0e3cf852de Merge: c528dc6d 84ece42 Author: Ashley <ashley.ruglys@gmail.com> Date: Wed Dec 4 17:11:39 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit c528dc6df8fc31cdcbc10889636355241398debd Author: Ashley <ashley.ruglys@gmail.com> Date: Wed Dec 4 17:07:00 2019 +0100 Fix wasm build commit da233a122c678dc7767dac7cc6e2564575b15cc8 Author: Ashley <ashley.ruglys@gmail.com> Date: Wed Dec 4 16:25:49 2019 +0100 tidy commit 832f8054df78afbcef1903e0f9e7e246b348c10d Merge: 4e1da888 78e828d Author: Ashley <ashley.ruglys@gmail.com> Date: Wed Dec 4 15:56:56 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit 4e1da8888dd2160064dd453782fb05513c65ade4 Author: Ashley <ashley.ruglys@gmail.com> Date: Tue Dec 3 16:47:02 2019 +0100 Temp switch back to substrate/master commit af88a87338688797bbc52315fdd0fc22cf23c6cf Merge: a03a980c abb5111 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 19:33:14 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit a03a980ce417ec7b446bfcbe7a66ec0ed6458135 Merge: 31a88a93 f7d4826 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 13:52:37 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit 31a88a930ffdf5da72b3e587ec8c0e6b00922e3e Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 13:52:35 2019 +0100 Tidy commit 5b33b7a7af08d7a3aa3853b8e4995484fb640d52 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 11:55:51 2019 +0100 Add browser-demo commit 868f6e51dfdc0a64252acd9adabe7b9ba436b1f4 Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 10:51:57 2019 +0100 Add initial browser file commit e5e399c20f1dc4e1023ee57773dcdd9ab2a0a14b Author: Ashley <ashley.ruglys@gmail.com> Date: Mon Dec 2 10:45:02 2019 +0100 Add browser-demo commit 408288b05292d952944a6b8e1f2bcf9cf259a040 Author: Ashley <ashley.ruglys@gmail.com> Date: Sun Dec 1 19:28:33 2019 +0100 Get polkadot to compile via wasm! commit 04ffe72e868be57841d31f01eec1b90423a595d6 Author: Ashley <ashley.ruglys@gmail.com> Date: Sun Dec 1 19:28:16 2019 +0100 Migrate service commit 119f0829a53b825a3ebc9efdefa76ae7eabb04aa Merge: 93fb6428 5422684 Author: Ashley <ashley.ruglys@gmail.com> Date: Sun Dec 1 17:43:49 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit 93fb6428501bac612a1675cf3b6e3d26f5bbc7c2 Author: Ashley <ashley.ruglys@gmail.com> Date: Sun Dec 1 12:21:25 2019 +0100 Switch branch commit 0c4fe8331bdc9665ac2427eb8c795112ac728d70 Author: Ashley <ashley.ruglys@gmail.com> Date: Sat Nov 30 11:45:59 2019 +0100 Tidy up validation commit 73563253d95962657108820ae130a8d3f3093ee8 Author: Ashley <ashley.ruglys@gmail.com> Date: Sat Nov 30 11:39:09 2019 +0100 Tidy up network commit 1c9cf0427c0e2d15c4b6d52b91d67d4a3963e30d Author: Ashley <ashley.ruglys@gmail.com> Date: Sat Nov 30 01:16:35 2019 +0100 Final changes to validation commit 322cca5224fdca0a29d88ff91700ef704a9d0c2a Author: Ashley <ashley.ruglys@gmail.com> Date: Sat Nov 30 00:31:55 2019 +0100 Migrate network to std futures commit 96f1a99491f5ae2957effa58cc1e385014575a32 Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Nov 29 23:31:04 2019 +0100 Migrate validation to std futures commit aaf5e55fffd1367c05687eb34f4365a24e3a34c0 Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Nov 29 17:10:11 2019 +0100 Switch to Spawn trait commit 2ab282f57e8b9a55cf8d285b283cf009216511d2 Merge: cceb6b72 5598ed9 Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Nov 29 16:31:24 2019 +0100 Merge remote-tracking branch 'parity/master' into ashley-compile-to-wasm commit cceb6b72f5677a1c43d2cd61bd525539054f0c01 Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Nov 29 15:47:14 2019 +0100 Make validation work on wasm! commit b45a95cf7d829a916bf2ad6936d1e7f4b6f3ef77 Merge: 3773d5c db7eaa6b Author: Ashley <ashley.ruglys@gmail.com> Date: Fri Nov 29 13:57:23 2019 +0100 Merge remote-tracking branch 'tomaka/wasm-start' into HEAD commit db7eaa6bd5d3bbcea829570fb47ab4d06f3558ce Merge: 6f97dbb7 2ab32da Author: Pierre Krieger <pierre.krieger1708@gmail.com> Date: Thu Nov 28 13:58:15 2019 +0100 Merge branch 'master' into wasm-start commit 6f97dbb786750d854cf8f7a56c6a336ea5979228 Author: Pierre Krieger <pierre.krieger1708@gmail.com> Date: Thu Nov 28 12:47:45 2019 +0100 Use --manifest-path instead commit 20104e98ff1713b6c81b0251b43d060d4e672d55 Author: Pierre Krieger <pierre.krieger1708@gmail.com> Date: Thu Nov 28 10:44:51 2019 +0100 Make availability-store compile for WASM * Fix build * Fix futures blocking panic in validators (again) * Deindent * Supercede 'Propagate Substrate#4284 to Polkadot' (paritytech#695) * Propagate Substrate#4284 to Polkadot * Fix tests * Fixes * Use hash part of fund id as child unique id. * Add comma * Switch branch * run cargo update * Update polkadot-master only * Fix collator * More update * Fix compilation * Some stylistic cleanups * Increase the minimum treasury bond to reduce silly proposals (paritytech#701) * Increase the minimum treasury bond to reduce silly proposals * Bump substrate * Bump version * Update to latest Substrate master (paritytech#703) * Update to latest Substrate master * Fix tests * Introduce an event for when transaction fees are paid (paritytech#702) * Introduce an event for when transaction fees are paid * Fix Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Bump to latest Substrate (paritytech#706) * Updates, but won't build. * Bump version. * Fix * Fix test * ci: increase git cloning depth to 100 (paritytech#707) * ci: fetch master branch for runtime diff (paritytech#708) * Bump Substrate and runtime version (paritytech#712) * Update to latest Substrate master * Bump Substrate and runtime version Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * ci: fix release tagging after tags are added on the master branch (paritytech#714) * ci: fix release tagging after tags are added on the master branch * ci: latest tag applied to latest tag * Update kvdb version in availability-store (paritytech#709) * update availability store * also fix warning * update Cargo.lock * Support both polkadot and kusama runtimes (paritytech#704) * Allow both polkadot and kusama runtimes * Allow both polkadot and kusama runtimes * Make `collator` build * Removed kusama runtime * Introduced common runtime * Updated for latest substrate * Updated CI targets * Updated CI version check * Removed unused dependency * Pulled latests substrate * Pulled latest substrate * Fixed version * Apply suggestions from code review Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> * NEW_HEADS_IDENTIFIER moved to primitives * Updated CI check script * Fixed script * Set epoch duration for polkadot * ci: check_runtime for both runtimes Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: gabriel klawitter <gabreal@users.noreply.github.com> * Bump Substrate & runtime version (paritytech#715) * Bump Substrate & runtime version * Attempt at fix * Update runtime/kusama/src/lib.rs Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update copyright year (paritytech#718) * Fixes after master merge * service: support setting fork blocks in config (paritytech#719) * ci: make sure master branch is available for check_runtime (paritytech#720) * service/src/lib.rs: Register network event stream for authority disc (paritytech#678) * service/src/lib.rs: Register network event stream for authority disc Previously one would create a sender and receiver channel pair, pass the sender to the build_network_future through the service builder and funnel network events returned from polling the network service into the sender to be consumed by the authority discovery module owning the receiver. With recent changes it is now possible to register an event_stream with the network service directly, thus one does not need to make the detour through the build_network_future. This commit is an adjusted clone of one targeting the Substrate repository. * service/src/lib.rs: Fix futures::stream imports * [TMP] *: Replace polkadot-upstream with feature branch * Revert "[TMP] *: Replace polkadot-upstream with feature branch" This reverts commit 0c947b04ab80488bfca16c5aeac9657b77a93a44. * Hotfix for Kusama (paritytech#724) * cli: revert borked kusama chain on startup * Docs. * cli: fix reversal of bork kusama fork * cli: force always can author * Version bump * service: support setting fork blocks in config * service: add support for bad blocks extension * service: add badBlocks to kusama chainspec * Bump Substrate to hotfix version. * service: add bad block to kusama chain spec * cleanup kusama hotfix * add kusama grandpa hotfix * Bump substrate * Bump spec_version * Rebump * cli: remove unnecessary dependencies * service: revert can_author_with fix * service: remove unnecessary method * Don't try to track polkadot runtime verion yet * Versions * service: better grandpa fix detection Co-authored-by: André Silva <andre.beat@gmail.com> * allow release alerts to fail (paritytech#725) * Fix the can-author issue by defaulting to Kusama when no chainspec given. (paritytech#728) * Fix can_author by defaulting correctly. * Comments * Better logging * Bump Substrate * Minor updates to readme. * service: reset grandpa into a future round (not past) (paritytech#726) * service: reset grandpa into a future round (not past) * update substrate version * service: create grandpa reset round variable * service: fine grained grandpa reset on startup Co-authored-by: Gavin Wood <github@gavwood.com> * Bump version (paritytech#729) * polkadot v0.7.13 (paritytech#730) * bump substrate version * bump version to 0.7.13 * Fix pending-release alert script (paritytech#734) ... parity/tools doesn't have /bin/bash * Select native runtime based on chain spec (paritytech#733) * Select native runtime based on chain spec * Bumped substrate * Add sudo module to `polkadot-runtime` (paritytech#735) * Bump versions (paritytech#736) * Fix up Kusama balance constants * Bump versions * Fix for the --dev option * remove kusama fixes (paritytech#738) * Tweak Polkadot constants & bump Substrate (paritytech#739) * Tweak Polkadot constants. * Bump and remove warning * Bump impl version * Bump Substrate * Bump Substrate again * Some fixes * Fix compilation * Remove TODO * Remove old dir * Companion PR for Substrate#4585 (paritytech#748) * Companion PR for Substrate#4394 (paritytech#723) * service/src/lib.rs: Register network event stream for authority disc Previously one would create a sender and receiver channel pair, pass the sender to the build_network_future through the service builder and funnel network events returned from polling the network service into the sender to be consumed by the authority discovery module owning the receiver. With recent changes it is now possible to register an event_stream with the network service directly, thus one does not need to make the detour through the build_network_future. This commit is an adjusted clone of one targeting the Substrate repository. * service/src/lib.rs: Fix futures::stream imports * [TMP] *: Replace polkadot-upstream with feature branch * Switch branch * Small change * Companion PR to substrate#4542 * Revert "Merge remote-tracking branch 'tomaka/companion-4542' into ashley-browser-utils" This reverts commit 17f00afe483ee65cb3cf4a0faca27034e6d6523a, reversing changes made to 928cbb9c55542baff56b53accd9a5a45f12f01f1. * ashley-browser-utils -> ashley-browser-utils-polkadot * Switch branches back Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * Companion PR to substrate#4542 (paritytech#732) * Companion PR for Substrate#4585 Co-authored-by: Ashley <ashley.ruglys@gmail.com> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * Reset branch and make it compile * Review feedback * Make the bounds a bit cleaner. Co-authored-by: Gavin Wood <github@gavwood.com> Co-authored-by: Stanislav Tkach <stanislav.tkach@gmail.com> Co-authored-by: Leo Arias <elopio@openzeppelin.com> Co-authored-by: Ashley <ashley.ruglys@gmail.com> Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com> Co-authored-by: s3krit <pugh@s3kr.it> Co-authored-by: Kirill Pimenov <kirushik@gmail.com> Co-authored-by: gabriel klawitter <gabreal@users.noreply.github.com> Co-authored-by: Nikolay Volf <nikvolf@gmail.com> Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: André Silva <andre.beat@gmail.com> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

gavofyork added 2 commits September 6, 2018 17:15

System and Balances switched to new call model

e115382

Fixed up executive for new pardigm

9f554f8

gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Sep 6, 2018

gavofyork added 18 commits September 6, 2018 17:52

Merge remote-tracking branch 'origin/master' into gav-origin

6cd6a43

Consensus works with Origin

8ba8dc6

Timestamp ported over

2488e69

Session now compatible

c05a9ce

Ported staking

e84ce49

Treasury compatible

c8a993b

Expunge MaybeEmpty

3d4f393

Make democracy work

f1a1e6a

Council compatible

7ab1505

Remove some aux-dispatch stuff and fix balances

5e4c1c4

Rename aux -> origin, fix contracts

eb00970

Fix test

7aaf272

Fix example

76200ae

Update macro to remove superfluous cruft

85af6e4

Make work with new macro

e12d868

Tests

57ad283

Fix some tests

52deb5c

Tests

221a851

gavofyork added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Sep 7, 2018

gavofyork requested review from bkchr, arkpar and pepyakin September 7, 2018 09:41

bkchr reviewed Sep 7, 2018

View reviewed changes

pepyakin reviewed Sep 7, 2018

View reviewed changes

pepyakin and others added 2 commits September 7, 2018 15:20

Merge remote-tracking branch 'origin/master' into gav-origin

4b2b0cb

Merge.

d03fe09

Fix grumbles

1e92641

Merge branch 'gav-origin' of github.com:paritytech/substrate into gav…

9b3d2ab

…-origin

pepyakin approved these changes Sep 7, 2018

View reviewed changes

pepyakin added A8-looksgood and removed A0-please_review Pull request needs code review. labels Sep 7, 2018

Final grumble

0abbb30

gavofyork merged commit da05763 into master Sep 7, 2018

gavofyork deleted the gav-origin branch September 7, 2018 17:28

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023

Upgrade clap to v4 (paritytech#678)

6cfd3bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New extrinsic dispatch model #678

New extrinsic dispatch model #678

gavofyork commented Sep 6, 2018 •

edited

Loading

bkchr Sep 7, 2018

bkchr Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

pepyakin Sep 7, 2018

gavofyork commented Sep 7, 2018

New extrinsic dispatch model #678

New extrinsic dispatch model #678

Conversation

gavofyork commented Sep 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork commented Sep 7, 2018

gavofyork commented Sep 6, 2018 •

edited

Loading