Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upgrade to a revocable session #368

Merged

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Nov 7, 2017

This adds ParseSession::upgradeToRevocableSession, which mirrors the name of the endpoint it utilizes to upgrade an existing session to a revocable one. Adds appropriate tests as needed to verify that the current user is also updated to reflect this, both on the server and locally in storage.

@montymxb montymxb added this to the 1.4.0 milestone Nov 7, 2017
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #368 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +<.01%     
==========================================
  Files          36       36              
  Lines        3389     3407      +18     
==========================================
+ Hits         3353     3371      +18     
  Misses         36       36
Impacted Files Coverage Δ
src/Parse/ParseSession.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f3dffe...0e36878. Read the comment docs.

@montymxb montymxb merged commit 89f2f32 into parse-community:master Nov 8, 2017
@montymxb montymxb deleted the upgrade-to-revocable-session branch November 8, 2017 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant