Adds ability to run livequery server on different port (appengine) #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acinader
approved these changes
Oct 19, 2016
| @@ -199,7 +199,7 @@ export default { | |||
| help: "Run with cluster, optionally set the number of processes default to os.cpus().length", | |||
| action: numberOrBoolParser("cluster") | |||
| }, | |||
| "liveQuery.classNames": { | |||
There was a problem hiding this comment.
why was it classNames? did that even work?
There was a problem hiding this comment.
nope that didn't :/
There was a problem hiding this comment.
it was a duplicate of the next one, that would let you pass --liveQuery.classNames options easily
| ParseServer.createLiveQueryServer(server, options.liveQueryServerOptions); | ||
| let liveQueryServer = server; | ||
| if (options.liveQueryPort) { | ||
| liveQueryServer = express().listen(options.liveQueryPort, function() { |
There was a problem hiding this comment.
yep fat arrow :)
| let liveQueryServer = server; | ||
| if (options.liveQueryPort) { | ||
| liveQueryServer = express().listen(options.liveQueryPort, function() { | ||
| console.log('ParseLiveQuery listening on '+options.liveQueryPort); |
There was a problem hiding this comment.
i prefer spaces around operators. ymmv
There was a problem hiding this comment.
yep i'll change that.
|
@acinader still looking good? |
|
@flovilmart updated the pull request - view changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppEngine should run the live query server on a different port, this let just do that from the CLI