Finding areas that are untested and need love #4131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4131 +/- ##
==========================================
+ Coverage 90.84% 92.08% +1.24%
==========================================
Files 116 116
Lines 8028 7960 -68
==========================================
+ Hits 7293 7330 +37
+ Misses 735 630 -105
Continue to review full report at Codecov.
|
flovilmart
force-pushed
the
coverage-nits
branch
2 times, most recently
from
7c3e67e to
ff25ba1
Compare
flovilmart
changed the title
- Fixes issue with small requests (0-2)
This reverts commit e2d2a16.
- A note mentioned that it would be possible to leverage using the indexes on username/email to infer which is duplicated
flovilmart
force-pushed
the
coverage-nits
branch
from
8c6b29a to
8cd7eb0
Compare
|
@acinader I'm done with that one! :)
|
acinader
suggested changes
Sep 5, 2017
src/RestWrite.js
Outdated
| @@ -1011,9 +1011,19 @@ RestWrite.prototype.runDatabaseOperation = function() { | |||
| if (this.className !== '_User' || error.code !== Parse.Error.DUPLICATE_VALUE) { | |||
| throw error; | |||
| } | |||
|
|
|||
| // Quick check, if we were able to infer the duplicated field name | |||
| if (error && error.userInfo && error.userInfo.duplicated_field == 'username') { | |||
| } | ||
|
|
||
| function getRange(req) { | ||
| const parts = req.get('Range').replace(/bytes=/, "").split("-"); |
There was a problem hiding this comment.
prefer ' to ". stay consistent
| } | ||
|
|
||
| // handleFileStream is licenced under Creative Commons Attribution 4.0 International License (https://creativecommons.org/licenses/by/4.0/). | ||
| // Author: LEROIB at weightingformypizza (https://weightingformypizza.wordpress.com/2015/06/24/stream-html5-media-content-like-video-audio-from-mongodb-using-express-and-gridstore/). | ||
| function handleFileStream(stream, req, res, contentType) { | ||
| var buffer_size = 1024 * 1024;//1024Kb | ||
| const buffer_size = 1024 * 1024; //1024Kb |
src/Routers/FilesRouter.js
Outdated
| end = start + (buffer_size); | ||
| } | ||
| chunksize = (end - start) + 1; | ||
| // No start profided, we're reading backwards |
There was a problem hiding this comment.
typo in the comment: profided
| //totalbytes = 0; | ||
| // in case of small slices, all values will be good at that point | ||
| // we've written enough, end... | ||
| if (totalBytesWritten >= contentLength) { |
There was a problem hiding this comment.
I'm no expert at js io. is there a try / catch / finally idiom?
maybe something like: https://stackoverflow.com/questions/4092914/java-try-catch-finally-best-practices-while-acquiring-closing-resources
There was a problem hiding this comment.
uhm, I'm not sure, I kept the original code there, as it work working as expected, the changes I put in were just because the code was a duplicate. if it throws, express will catch it :)
acinader
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.