Fixes #2885 duplicate sessions #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sessions will also be created with action login instead of signup when using 3rd party auth
Codecov Report
@@ Coverage Diff @@
## master #4143 +/- ##
==========================================
+ Coverage 92.11% 92.14% +0.02%
==========================================
Files 116 116
Lines 7982 7982
==========================================
+ Hits 7353 7355 +2
+ Misses 629 627 -2
Continue to review full report at Codecov.
|
natanrolnik
approved these changes
Sep 11, 2017
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #2885 where successive login calls would create multiple sessions / user-installationId pair