Skip to content

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 28, 2020


🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io


The dependency mongodb was updated from 3.5.7 to 3.5.8.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: mbroadst
License: Apache-2.0

Release Notes for v3.5.8

The MongoDB Node.js team is pleased to announce version 3.5.8 of the driver

Release Highlights

Fixes for NEAREST latency window calculation

@adityapatadia helped uncover an issue with our server selection logic which
filtered out servers after evaluating whether they were in the latency window.
This meant that non-viable servers were considered during the window calculation
and would render certain viable servers unviable.

BulkWriteError writeErrors property

@vkarpov15 submitted a patch to always include writeErrors on a BulkWriteError.
We have logic to set the message of BulkWriteError to the message of the first
error encountered if there is only one error. Unfortunately, this logic removed
the writeErrors field when doing that, so users could be faced with an error
which conditionally changed shape.

Memory leak in timed out wait queue members

@dead-horse identified a memory leak in the new connection pool where wait queue
members which timed out might be left in the queue indefinitely under sufficient
load. The fix here was to ensure that all wait queue members are flushed during
wait queue processing before evaluating whether there were available sockets to
process new requests.

Implicit sessions cleanup improvements

Once @dead-horse was able to patch the connection pool memory leak, they also
identified a edge case where implicit sessions could be leaked in a very specific
error condition. The logic to release implicit sessions was simplified, preventing
this from happening in the future

Unordered bulk writes continue-on-error

A bug introduced last summer prevented unordered bulk write operations from
continuing after the first write error - one of the most important features of
being an unordered operation. We now properly support this feature again.

journal in connection string is ignored

@nknighter filed a report that the journal option was ignored when provided
via the connection string. The paramater j was supported both through the
connection string and explicit added to MongoClient options, but the official
documentation for connection strings support a journal option.

Documentation

Reference: http://mongodb.github.io/node-mongodb-native/3.5/
API: http://mongodb.github.io/node-mongodb-native/3.5/api/
Changelog: https://github.com/mongodb/node-mongodb-native/blob/3.5/HISTORY.md

We invite you to try the driver immediately, and report any issues to the NODE project.

Thanks very much to all the community members who contributed to this release!

Release Notes

Bug

  • [NODE-2407] - UnifiedTopology + near read makes application crash with timeout error when one of replica server is down
  • [NODE-2413] - The node process enters an infinite loop at the pool and causes OOM
  • [NODE-2442] - journal=true is ignored in connection string
  • [NODE-2548] - Change streams do not resume from errors
  • [NODE-2565] - Change stream should not check for NonResumableChangeStreamError label
  • [NODE-2619] - Unordered bulk write aborts on first encountered error
  • [NODE-2625] - BulkWriteError should always have a writeErrors field

Task

  • [NODE-2478] - Use white list for change stream resumability
  • [NODE-2598] - Change stream close refactor
  • [NODE-2605] - Refactor shared test helpers to improve usability

Improvement

  • [NODE-2522] - Remove ElectionInProgress (216) from ResumableChangeStreamError
  • [NODE-2571] - Don't use admin database for FLE tests
  • [NODE-2630] - Simplify code path for ending implicit sessions in cursors
Commits

The new version differs by 14 commits.

  • 9c4288c chore(release): 3.5.8
  • 5c6fda1 fix: ensure implicit sessions are ended consistently
  • 0394f9d fix: always clear cancelled wait queue members during processing
  • 58b4f94 fix: always include writeErrors on a BulkWriteError instance
  • 6cee96b fix: unordered bulk write should attempt to execute all batches
  • 4faf9f5 fix: filter servers before applying reducers
  • 5ecf18e fix(ChangeStream): should resume from errors when iterating
  • 7fad15a test: improve shared helpers
  • 246669f fix: honor journal=true in connection string (#2359)
  • 1e3b4c9 refactor(ChangeStream): use maybePromise for close, improve tests
  • 5e7197a test: ignore error for missing killAllSessions on legacy versions
  • 4f987f1 refactor: don't use admin database in CSFLE tests
  • a9d3965 fix(ChangeStream): whitelist resumable errors (#2337)
  • 922c3ab test: use a different conflicting option for index error validation

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #6719 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6719   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files         169      169           
  Lines       12029    12029           
=======================================
+ Hits        11295    11296    +1     
+ Misses        734      733    -1     
Impacted Files Coverage Δ
src/RestWrite.js 93.84% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a743ca...c596334. Read the comment docs.

@ghost ghost merged commit d0a9c70 into master May 28, 2020
@greenkeeper greenkeeper bot deleted the greenkeeper/mongodb-3.5.8 branch May 28, 2020 13:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants