Skip to content

Conversation

lamualfa
Copy link
Contributor

@lamualfa lamualfa commented Nov 3, 2020

No description provided.

@ghost
Copy link

ghost commented Nov 3, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #6990 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6990   +/-   ##
=======================================
  Coverage   93.81%   93.82%           
=======================================
  Files         169      169           
  Lines       12409    12405    -4     
=======================================
- Hits        11642    11639    -3     
+ Misses        767      766    -1     
Impacted Files Coverage Δ
src/RestWrite.js 93.65% <0.00%> (-0.33%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.87% <0.00%> (-0.02%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.58% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c983202...ac5ba95. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fail in the case there is no main.js file in the folder. Maybe we should add a note.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. LGTM!

@davimacedo davimacedo merged commit ccb6c04 into parse-community:master Nov 3, 2020
dblythy pushed a commit to dblythy/parse-server that referenced this pull request Dec 14, 2020
…-community#6990)

* Add `cloud` parameter to Docker command (parse-community#6988)

* Add note to run Image with Cloud Code feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants