-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: GraphQL playground shows blank page #9858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GraphQL playground shows blank page #9858
Conversation
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughAdjusts how JSON-stringified values are embedded in the generated client-side sandbox code within ParseGraphQLServer.js, removing extra quoting so the EmbeddedSandbox receives plain string values for initialEndpoint and specific headers. No server-side logic or public APIs are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/GraphQL/ParseGraphQLServer.js
(1 hunks)
🔇 Additional comments (1)
src/GraphQL/ParseGraphQLServer.js (1)
170-170
: Correct fix for double-quoting; resolves the blank page.Inlining JSON.stringify without surrounding quotes is the right approach here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right, I have this change on my fork, and it seems I forgot to open a PR to parse-server
@cryingraven just a reminder that playground path should only be used in dev/local, not in production (because it expose the master key) |
@mtrezza we should merge this asap |
close: #9057 |
Started CI |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #9858 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 187 187
Lines 15096 15096
Branches 174 174
=======================================
Hits 14039 14039
Misses 1045 1045
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a flaky here @mtrezza i think it's ready to merge ! |
## [8.2.5-alpha.1](8.2.4...8.2.5-alpha.1) (2025-09-21) ### Bug Fixes * GraphQL playground shows blank page ([#9858](#9858)) ([7b5395c](7b5395c))
🎉 This change has been released in version 8.2.5-alpha.1 |
## [8.2.5](8.2.4...8.2.5) (2025-10-02) ### Bug Fixes * GraphQL playground shows blank page ([#9858](#9858)) ([7b5395c](7b5395c))
🎉 This change has been released in version 8.2.5 |
this fixes the error when activating graphql playground and opening it in the browser. the page is blank.
"${JSON.stringify(this.config.graphQLPath)}" the result -> ""/graphql""
by removing the double quotes
${JSON.stringify(this.config.graphQLPath)} the result -> "/graphql"
and the problem fixed
Summary by CodeRabbit