Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for delete stream API for distributed #766

Merged

Conversation

nikhilsinhaparseable
Copy link
Contributor

change - querier deletes the stream folder from the storage
then calls delete stream API for each ingester
ingester deletes the stream from its local map

Fixes #763 .

change - querier deletes the stream folder from the storage
then calls delete stream API for each ingester
ingester deletes the stream from its local map
Copy link
Contributor

@Eshanatnight Eshanatnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nitisht nitisht merged commit fb8a105 into parseablehq:main Apr 18, 2024
6 checks passed
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
with this PR, when delete stream is called, querier 
deletes the stream folder from the storage then calls 
delete stream API for each ingestor. Finally, ingestor 
deletes the stream from its local map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Delete Stream for Distributed
3 participants