Skip to content

Add new flights parameters #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2021
Merged

Add new flights parameters #41

merged 2 commits into from
Sep 7, 2021

Conversation

pcothenet
Copy link
Contributor

What

  • Support for new flight parameters

Why

  • More accurate estimates

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from boconnell2 September 5, 2021 22:11
@pcothenet pcothenet mentioned this pull request Sep 7, 2021
Merged
5 tasks
kleinjm
kleinjm approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing test seems unrelated

@pcothenet pcothenet merged commit 27d3662 into main Sep 7, 2021
@pcothenet pcothenet deleted the pc/flights branch September 7, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinjm kleinjm kleinjm approved these changes

@boconnell2 boconnell2 Awaiting requested review from boconnell2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @kleinjm