Skip to content

Validate params before request #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 7, 2021
Merged

Validate params before request #42

merged 6 commits into from
Sep 7, 2021

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Sep 7, 2021 •
edited
Loading

What

  • Validates body parameters before making the HTTP requests

Why

Notes

  • Add new flights parameters #41 should be reviewed and merged first (this is built on top)
  • This is less interesting for node than for ruby (the class generation does not throw an error if a parameter is not accepted, it just gets rid of it)

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from kleinjm September 7, 2021 16:29
kleinjm
kleinjm reviewed Sep 7, 2021
View reviewed changes
.github/workflows/publish.yml Outdated
@@ -16,7 +16,7 @@ jobs:
name: Create GitHub deployment
id: deployment
with:
token: "${{ github.token }}"
token: '${{ github.token }}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this causing any issues or is this just a style preference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Automatic setting from prettier in the pre-commit hook. Not sure why it didn't update when I made the change initially

pcothenet
pcothenet commented Sep 7, 2021
View reviewed changes
test/integration/preferences.test.js
const retrieveProjectResponse = await patch.projects.retrieveProjects();
return retrieveProjectResponse.data[0].id;
}

describe('Preferences Integration', async function () {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kleinjm I bit the bullet and rewrote this test in the same style as the Ruby one.

@pcothenet pcothenet merged commit 1d8d5bb into main Sep 7, 2021
@pcothenet pcothenet deleted the pc/params branch September 7, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinjm kleinjm kleinjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @kleinjm