Cannot find module 'ws'

[jsyrjala]

I am getting this error: Cannot find module 'ws' from '/home/some/path/myproject/node_modules/angular-websocket'

I think this is because I use http://browserify.org/ and angular-websocket has this code.

   // CommonJS
  if (typeof exports === 'object' && require) {
    try {
      ws = require('ws');
      Socket = (ws.Client || ws.client || ws);
    } catch(e) {}
  }

  // Browser
  Socket = Socket || $window.WebSocket || $window.MozWebSocket;

[jsyrjala]

Maybe it should first check if running in browser with WebSockets and only if that fails try with CommonJS?

 Socket = $window.WebSocket || $window.MozWebSocket;
 if (!Socket && typeof exports === 'object' && require) {
   try {
     ws = require('ws');
     Socket = (ws.Client || ws.client || ws);
   } catch(e) {}
 }

[PatrickJS]

Thanks for submitting the issue if you can submit a PR that I'll merge it in otherwise I'll update the repo later today. There are many different environments the code can run in so I was trying to see if I can account for most of them. The current workaround you can do is overwriting the backend service by creating a service with the same name as $websocketBackend with a method of createWebSocketBackend(url, protocols) that returns an instance of WebSocket. Or create a module named ws that returns the WebSocket constructor

[jsyrjala]

Changing order of browser and CommonJS blocks doesn't work. I guess, Browserify will scan the file for require(xxx) commands regardless of any conditionals. So the correct way to fix this is to add ws dependency to you project.

[jsyrjala]

So solution seems to be to npm install ws. But why angular-websocket wants to use nodejs' websocket implementation? Is it because of unit-tests?

[PatrickJS]

it shouldn't need it I'll setup an example repo with browserify and push a fix for you

[PatrickJS]

I got it working with browserify and added an example. It's considered best practice to require your dependencies so I made ws a dependency. Since ws returns the global websocket https://github.com/websockets/ws/blob/master/lib/browser.js it's fine to include it in your bundle. I released an updated version 1.0.9 for you

[jsyrjala]

Thanks! I tested the new version with my project. Works fine.

[lionelB]

@gdi2290 FYI, ws no longer support browser env.
see websockets/ws@e54d45f