-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(DragDrop): deprecate in v6 #10181
Conversation
Preview: https://patternfly-react-pr-10181.surge.sh A11y report: https://patternfly-react-pr-10181-a11y.surge.sh |
@kmcfaul Can we update those examples to use the new drag and drop? Or are you asking if the even belong in the examples pages to begin with? |
@tlabaj Bit of both. We have updated examples for those two components already, but they currently live in the Drag and Drop page's demo tab. I mostly wonder if we want to move those old examples to the deprecated Drag and Drop page, and if we want to move the new examples to the respective component pages. |
If we're not sure we can probably open a docs followup to update the documentation to let this PR in |
Per working session discussion, I'm adding a deprecated flag to the current examples and opening #10196 to follow up updating the documentation with the new demos. |
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10096
@tlabaj Do we want to move any of the old DragDrop examples? Currently there are examples using the now deprecated DragDrop on DataList and DualListSelector (current and next). Should we move those onto DragDrop's
React deprecated
page now? We do have examples for DataList/DualListSelector using the newerDragDropSort
but they only live on theReact next demos
page currently.