Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DragDrop): deprecate in v6 #10181

Merged
merged 3 commits into from
Mar 27, 2024
Merged

chore(DragDrop): deprecate in v6 #10181

merged 3 commits into from
Mar 27, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Mar 19, 2024

What: Closes #10096

@tlabaj Do we want to move any of the old DragDrop examples? Currently there are examples using the now deprecated DragDrop on DataList and DualListSelector (current and next). Should we move those onto DragDrop's React deprecated page now? We do have examples for DataList/DualListSelector using the newer DragDropSort but they only live on the React next demos page currently.

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 19, 2024

@kmcfaul kmcfaul linked an issue Mar 20, 2024 that may be closed by this pull request
@tlabaj tlabaj requested review from a team, nicolethoen and tlabaj and removed request for a team March 21, 2024 20:20
@tlabaj
Copy link
Contributor

tlabaj commented Mar 22, 2024

@tlabaj Do we want to move any of the old DragDrop examples? Currently there are examples using the now deprecated DragDrop on DataList and DualListSelector (current and next). Should we move those onto DragDrop's React deprecated page now? We do have examples for DataList/DualListSelector using the newer DragDropSort but they only live on the React next demos page currently.

@kmcfaul Can we update those examples to use the new drag and drop? Or are you asking if the even belong in the examples pages to begin with?

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Mar 25, 2024

@tlabaj Bit of both. We have updated examples for those two components already, but they currently live in the Drag and Drop page's demo tab. I mostly wonder if we want to move those old examples to the deprecated Drag and Drop page, and if we want to move the new examples to the respective component pages.

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Mar 25, 2024

If we're not sure we can probably open a docs followup to update the documentation to let this PR in

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Mar 25, 2024

Per working session discussion, I'm adding a deprecated flag to the current examples and opening #10196 to follow up updating the documentation with the new demos.

@tlabaj tlabaj merged commit 2f09053 into patternfly:v6 Mar 27, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.46
  • @patternfly/react-core@6.0.0-alpha.46
  • @patternfly/react-docs@7.0.0-alpha.48
  • @patternfly/react-drag-drop@6.0.0-alpha.27
  • demo-app-ts@5.1.1-alpha.45
  • @patternfly/react-table@6.0.0-alpha.46

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V6 - Drag drop - Deprecate drag drop
4 participants