fix(Popper): updated default appendTo prop for Penta styling #10675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10675.surge.sh A11y report: https://patternfly-react-pr-10675-a11y.surge.sh |
dlabaj
approved these changes
Jun 29, 2024
nicolethoen
approved these changes
Jul 2, 2024
|
Are there any docs - in accessibilty docs or in component docs that advise against appending to document body that we will want to update as a result of this change? |
thatblindgeye
force-pushed
the
popperUpdateDefaultAppend
branch
from
4fbd4f9 to
02aa4f2
Compare
|
@nicolethoen not that I could find when searching document body or append in the org repo. I did update Dropdown and Select a teeny bit with the latest update, though. |
thatblindgeye
commented
Jul 2, 2024
| @@ -27,7 +27,6 @@ DualListSelectorListItem as DLSListItemDeprecated, | |||
| DualListSelectorControlsWrapper as DLSControlsWrapperDeprecated, | |||
| DualListSelectorControl as DLSControlDeprecated, | |||
| DualListSelectorTree as DLSTreeDeprecated, | |||
| DualListSelectorTreeItemData as DLSTreeItemDataDeprecated, | |||
There was a problem hiding this comment.
Note that this is unrelated to the PR itself, but should help remove the warning when building locally.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10671
Additional issues: