Skip to content

chore(Badge): update tests to new react testing library standards #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

samuelatefah
Copy link
Contributor

What: Closes #7994

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Sep 26, 2022

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I just have one small thing I'd like to be changed and it should be good to go!

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@nicolethoen nicolethoen merged commit b818f16 into patternfly:main Sep 29, 2022
@samuelatefah samuelatefah deleted the badge-test-revamp branch October 7, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge test revamp
4 participants