Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump v6 alphas #9881

Merged
merged 6 commits into from
Dec 13, 2023
Merged

chore(deps): Bump v6 alphas #9881

merged 6 commits into from
Dec 13, 2023

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Dec 12, 2023 •
edited
Loading

What: Closes #9882 Towards #9880, #9878, #9850

Changes to Avatar:

Expandable Section

  • Removed isActive prop

Pagination

  • removed pf-m-compact modifier

@tlabaj tlabaj changed the base branch from nicolethoen-patch-1 to v6 December 12, 2023 17:21
@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 12, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9881.surge.sh

A11y report: https://patternfly-react-pr-9881-a11y.surge.sh

This was referenced Dec 12, 2023
Closed
Closed
thatblindgeye
thatblindgeye requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change below

@tlabaj tlabaj requested a review from thatblindgeye December 13, 2023 19:39
thatblindgeye
thatblindgeye requested changes Dec 13, 2023
View reviewed changes
packages/react-core/src/components/Pagination/Pagination.tsx Outdated
@@ -359,7 +358,6 @@ export const Pagination: React.FunctionComponent<PaginationProps> = ({
onLastClick={onLastClick}
onPageInput={onPageInput}
isDisabled={isDisabled}
isCompact={isCompact}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to add this back as well so it can be passed to the Navigation

@tlabaj tlabaj requested a review from thatblindgeye December 13, 2023 20:40
@wise-king-sullyman wise-king-sullyman merged commit b58518f into patternfly:v6 Dec 13, 2023
@tlabaj tlabaj mentioned this pull request Dec 13, 2023
Closed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.4
  • @patternfly/react-code-editor@6.0.0-alpha.5
  • @patternfly/react-core@6.0.0-alpha.5
  • @patternfly/react-docs@7.0.0-alpha.5
  • @patternfly/react-icons@6.0.0-alpha.4
  • demo-app-ts@5.1.1-alpha.4
  • @patternfly/react-styles@6.0.0-alpha.4
  • @patternfly/react-table@6.0.0-alpha.5
  • @patternfly/react-tokens@6.0.0-alpha.4

Thanks for your contribution! 🎉

@tlabaj tlabaj mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlabaj @patternfly-build @wise-king-sullyman @thatblindgeye