fix(db-mongodb): findVersions/findGlobalVersions not respecting limit of 0 (#14573)

### What?
Updated `db-mongodb`'s `findVersions()` and `findGlobalVersions()`
functions to treat the `limit` property the same as the `find()` does.

### Why?
Currently, passing `limit: 0` to `findVersions` or `findGlobalVersions`
results in an empty array of documents. The reason being is the logical
AND present in these files when evaluating the `limit` property, which
will resolve to false when `limit === 0`, meaning that the nested `if
(limit === 0)` statement can never be reached

### How?
I've copied the approach from `find()`. This also defaults the `limit`
value to 0 as in `find()`, which may/not be desirable? I opted for
consistency across the functions rather than leaving the defaults
undefined and checking the types instead.

---------

Co-authored-by: German Jablonski <43938777+GermanJablo@users.noreply.github.com>
Co-authored-by: Sasha <64744993+r1tsuu@users.noreply.github.com>

Author: 3 people

packages/db-mongodb/src/findGlobalVersions.ts

@@ -16,7 +16,7 @@ export const findGlobalVersions: FindGlobalVersions = async function findGlobalV
   this: MongooseAdapter,
   {
     global: globalSlug,
-    limit,
+    limit = 0,
     locale,
     page,
     pagination,
@@ -101,7 +101,7 @@ export const findGlobalVersions: FindGlobalVersions = async function findGlobalV
     }
   }
 
-  if (limit && limit >= 0) {
+  if (limit >= 0) {
     paginationOptions.limit = limit
     // limit must also be set here, it's ignored when pagination is false
 

packages/db-mongodb/src/findVersions.ts

@@ -16,7 +16,7 @@ export const findVersions: FindVersions = async function findVersions(
   this: MongooseAdapter,
   {
     collection: collectionSlug,
-    limit,
+    limit = 0,
     locale,
     page,
     pagination,
@@ -109,7 +109,7 @@ export const findVersions: FindVersions = async function findVersions(
     }
   }
 
-  if (limit && limit >= 0) {
+  if (limit >= 0) {
     paginationOptions.limit = limit
     // limit must also be set here, it's ignored when pagination is false
 

test/_community/payload-types.ts

@@ -69,6 +69,7 @@ export interface Config {
   collections: {
     posts: Post;
     media: Media;
+    'payload-kv': PayloadKv;
     users: User;
     'payload-locked-documents': PayloadLockedDocument;
     'payload-preferences': PayloadPreference;
@@ -78,6 +79,7 @@ export interface Config {
   collectionsSelect: {
     posts: PostsSelect<false> | PostsSelect<true>;
     media: MediaSelect<false> | MediaSelect<true>;
+    'payload-kv': PayloadKvSelect<false> | PayloadKvSelect<true>;
     users: UsersSelect<false> | UsersSelect<true>;
     'payload-locked-documents': PayloadLockedDocumentsSelect<false> | PayloadLockedDocumentsSelect<true>;
     'payload-preferences': PayloadPreferencesSelect<false> | PayloadPreferencesSelect<true>;
@@ -188,6 +190,23 @@ export interface Media {
     };
   };
 }
+/**
+ * This interface was referenced by `Config`'s JSON-Schema
+ * via the `definition` "payload-kv".
+ */
+export interface PayloadKv {
+  id: string;
+  key: string;
+  data:
+    | {
+        [k: string]: unknown;
+      }
+    | unknown[]
+    | string
+    | number
+    | boolean
+    | null;
+}
 /**
  * This interface was referenced by `Config`'s JSON-Schema
  * via the `definition` "users".
@@ -334,6 +353,14 @@ export interface MediaSelect<T extends boolean = true> {
             };
       };
 }
+/**
+ * This interface was referenced by `Config`'s JSON-Schema
+ * via the `definition` "payload-kv_select".
+ */
+export interface PayloadKvSelect<T extends boolean = true> {
+  key?: T;
+  data?: T;
+}
 /**
  * This interface was referenced by `Config`'s JSON-Schema
  * via the `definition` "users_select".

test/versions/int.spec.ts

@@ -24,6 +24,7 @@ import {
   autosaveWithMultiSelectCollectionSlug,
   draftCollectionSlug,
   draftGlobalSlug,
+  draftUnlimitedGlobalSlug,
   localizedCollectionSlug,
   localizedGlobalSlug,
   versionCollectionSlug,
@@ -529,6 +530,23 @@ describe('Versions', () => {
           draftsDescending.docs[draftsDescending.docs.length - 1]!,
         )
       })
+
+      it('should findVersions with limit: 0', async () => {
+        const doc = await payload.create({
+          collection: draftCollectionSlug,
+          data: { description: 'a', title: 'test-doc' },
+        })
+
+        for (let i = 0; i < 100; i++) {
+          await payload.update({ collection: draftCollectionSlug, id: doc.id, data: {} })
+        }
+        const res = await payload.findVersions({
+          collection: draftCollectionSlug,
+          limit: 0,
+          where: { parent: { equals: doc.id } },
+        })
+        expect(res.docs).toHaveLength(101)
+      })
     })
 
     describe('Restore', () => {
@@ -2203,6 +2221,20 @@ describe('Versions', () => {
 
         expect(version.id).toStrictEqual(globalVersionID)
       })
+
+      it('should findGlobalVersions with limit: 0', async () => {
+        await payload.db.deleteVersions({ globalSlug: draftUnlimitedGlobalSlug, where: {} })
+        for (let i = 0; i < 100; i++) {
+          await payload.updateGlobal({ slug: draftUnlimitedGlobalSlug, data: { title: 'global' } })
+        }
+
+        const res = await payload.findGlobalVersions({
+          slug: draftUnlimitedGlobalSlug,
+          limit: 0,
+        })
+
+        expect(res.docs).toHaveLength(100)
+      })
     })
 
     describe('Update', () => {