fix(db-*): do not exit process on error during connect #14647
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
AlessioGr
commented
Nov 17, 2025
| @@ -1133,12 +1127,12 @@ | |||
| return cached.payload | |||
Member
Author
There was a problem hiding this comment.
Awaiting the promise is already wrapped in try{} catch {}. Feels weird not to wrap this floating promise execution in the same try {} catch {}
jessrynkar
approved these changes
Nov 18, 2025
Contributor
|
🚀 This is included in version v3.65.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
process.exit(1)from our exception handlers within db connect methods. When a connection error occurred in vercel fluid compute, it ungracefully shut down the entire compute process.By re-throwing the error instead, vercel is able to gracefully handle the error without shutting down concurrent requests running on the same compute instance.
process.exit(1) was initially added by this commit, however noone was able to recall why it was added.